OpenBIOS April 2010

openbios@openbios.org

14 participants
65 discussions

[commit] r743 - in trunk/openbios-devel: include/libc libc
by repository service 15 Apr '10

15 Apr '10

Author: blueswirl Date: Thu Apr 15 18:42:51 2010 New Revision: 743 URL: http://tracker.coreboot.org/trac/openbios/changeset/743 Log: Remove unused strspn() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:49 2010 (r742) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:51 2010 (r743) @@ -37,7 +37,6 @@ extern char *strrchr(const char * s, int c); extern size_t strlen(const char * s); extern size_t strnlen(const char * s, size_t count); -extern size_t strspn(const char *s, const char *accept); extern char *strpbrk(const char * cs,const char * ct); extern char *strsep(char **s, const char *ct); extern void *memset(void * s,int c,size_t count); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:49 2010 (r742) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:51 2010 (r743) @@ -221,31 +221,6 @@ } /** - * strspn - Calculate the length of the initial substring of @s which only - * contain letters in @accept - * @s: The string to be searched - * @accept: The string to search for - */ -size_t strspn(const char *s, const char *accept) -{ - const char *p; - const char *a; - size_t count = 0; - - for (p = s; *p != '\0'; ++p) { - for (a = accept; *a != '\0'; ++a) { - if (*p == *a) - break; - } - if (*a == '\0') - return count; - ++count; - } - - return count; -} - -/** * strpbrk - Find the first occurrence of a set of characters * @cs: The string to be searched * @ct: The characters to search for

1 0

[commit] r742 - in trunk/openbios-devel: include/libc libc
by repository service 15 Apr '10

15 Apr '10

Author: blueswirl Date: Thu Apr 15 18:42:49 2010 New Revision: 742 URL: http://tracker.coreboot.org/trac/openbios/changeset/742 Log: Remove unused strtok() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Mon Apr 12 22:02:53 2010 (r741) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:49 2010 (r742) @@ -39,7 +39,6 @@ extern size_t strnlen(const char * s, size_t count); extern size_t strspn(const char *s, const char *accept); extern char *strpbrk(const char * cs,const char * ct); -extern char *strtok(char * s,const char * ct); extern char *strsep(char **s, const char *ct); extern void *memset(void * s,int c,size_t count); extern char *bcopy(const char * src, char * dest, int count); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Mon Apr 12 22:02:53 2010 (r741) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:49 2010 (r742) @@ -50,8 +50,6 @@ return (int)c1 - (int)c2; } -static char * ___strtok; - /** * strcpy - Copy a %NUL terminated string * @dest: Where to copy the string to @@ -266,33 +264,6 @@ } /** - * strtok - Split a string into tokens - * @s: The string to be searched - * @ct: The characters to search for - * - * WARNING: strtok is deprecated, use strsep instead. - */ -char * strtok(char * s,const char * ct) -{ - char *sbegin, *send; - - sbegin = s ? s : ___strtok; - if (!sbegin) { - return NULL; - } - sbegin += strspn(sbegin,ct); - if (*sbegin == '\0') { - ___strtok = NULL; - return( NULL ); - } - send = strpbrk( sbegin, ct); - if (send && *send != '\0') - *send++ = '\0'; - ___strtok = send; - return (sbegin); -} - -/** * strsep - Split a string into tokens * @s: The string to be searched * @ct: The characters to search for

1 0

[PATCH] RFC: Increase dictionary size on SPARC64
by Mark Cave-Ayland 15 Apr '10

15 Apr '10

Hi all, Thanks to some great work by Igor, the reason for my random debugger crashes has been found. It appears that the default dictionary size is too small on SPARC64 and repeatedly updating the translations property is enough to cause the forth dictionary to overflow the memory allocated for it. I'd like to propose the attached patch which doubles the dictionary memory from 256k to 512k as currently used by PPC. My concern about applying the patch directly is that I'm not sure whether or not any corresponding changes to entry.S also need to be made. AFAICT the initialisation code handles 19 x 512k pages when setting up the MMU (which should be more than enough) but thought I should get a second opinion first. ATB, Mark. -- Mark Cave-Ayland - Senior Technical Architect PostgreSQL - PostGIS Sirius Corporation plc - control through freedom http://www.siriusit.co.uk t: +44 870 608 0063 Sirius Labs: http://www.siriusit.co.uk/labs

6 17

OBP under qemu-system-sparc64
by Artyom Tarasenko 14 Apr '10

14 Apr '10

2010/4/3 Blue Swirl <blauwirbel(a)gmail.com>: > could be interesting to see what OBP > from a real machine would think of the QEMU machine. it doesn't live long enough to think something (must be something trivial): $ sparc64-softmmu/qemu-system-sparc64 -bios u1_v3.11.1.bin -nographic -cpu 'TI UltraSparc I' -d in_asm,int,cpu -------------- IN: 0x000001fff0000020: ldxa [ %g0 ] (69), %g2 0x000001fff0000024: stxa %g0, [ %g0 ] (69) 0x000001fff0000028: b,a 0x1fff0001d88 -------------- IN: 0x000001fff0001d88: rdpr %cwp, %g1 0x000001fff0001d8c: wrpr 0, %cwp 0x000001fff0001d90: wrpr %g1, 0, %cwp 0x000001fff0001d94: call 0x1fff0000210 0x000001fff0001d98: add %g0, %g0, %o0 -------------- IN: 0x000001fff0000210: mov 0x1ff, %o1 ! 0x1ff 0x000001fff0000214: sllx %o1, 0x20, %o1 0x000001fff0000218: sethi %hi(0xf1300000), %o2 0x000001fff000021c: or %o2, %o1, %o2 0x000001fff0000220: stba %o0, [ %o2 ] (21) 0x000001fff0000224: add %o2, 4, %o2 0x000001fff0000228: lduba [ %o2 ] (21), %o1 0x000001fff000022c: sllx %o1, 8, %o0 0x000001fff0000230: inc %o2 0x000001fff0000234: lduba [ %o2 ] (21), %o1 0x000001fff0000238: or %o0, %o1, %o0 0x000001fff000023c: sllx %o0, 8, %o0 0x000001fff0000240: inc %o2 0x000001fff0000244: lduba [ %o2 ] (21), %o1 0x000001fff0000248: or %o0, %o1, %o0 0x000001fff000024c: sllx %o0, 8, %o0 0x000001fff0000250: inc %o2 0x000001fff0000254: lduba [ %o2 ] (21), %o1 0x000001fff0000258: or %o0, %o1, %o0 0x000001fff000025c: retl 0x000001fff0000260: nop qemu: fatal: Trap 0x0032 while trap level (5) >= MAXTL (5), Error state pc: 000001fff0000220 npc: 000001fff0000224 General Registers: %g0-3: 0000000000000000 0000000000000007 0000000000000000 0000000000000000 %g4-7: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 Current Register Window: %o0-3: 0000000000000000 000001ff00000000 000001fff1300000 0000000000000000 %o4-7: 0000000000000000 0000000000000000 0000000000000000 000001fff0001d94 %l0-3: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 %l4-7: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 %i0-3: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 %i4-7: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 Floating Point Registers: %f00: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f04: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f08: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f12: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f16: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f20: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f24: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f28: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f32: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f36: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f40: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f44: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f48: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f52: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f56: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 %f60: 000000000.000000 000000000.000000 000000000.000000 000000000.000000 pstate: 00000035 ccr: 00 (icc: ---- xcc: ----) asi: 00 tl: 5 pil: 0 cansave: 0 canrestore: 0 otherwin: 0 wstate: 0 cleanwin: 0 cwp: 7 fsr: 0000000000000000 y: 0000000000000000 fprs: 0000000000000000 Just in case, the properties of the real machine: ok cd / ok .properties breakpoint-trap 0000007f #size-cells 00000002 energystar-v2 model SUNW,501-2486 name SUNW,Ultra-1 clock-frequency 04f9f54d banner-name Sun Ultra 1 UPA/SBus (UltraSPARC 167MHz) device_type upa ok cd /SUNW,UltraSPARC ok .properties manufacturer# 00 00 00 17 implementation# 00 00 00 10 mask# 00 00 00 40 sparc-version 00 00 00 09 ecache-associativity 00 00 00 01 ecache-line-size 00 00 00 40 ecache-size 00 08 00 00 #dtlb-entries 00 00 00 40 dcache-associativity 00 00 00 01 dcache-line-size 00 00 00 20 dcache-size 00 00 40 00 #itlb-entries 00 00 00 40 icache-associativity 00 00 00 02 icache-line-size 00 00 00 20 icache-size 00 00 40 00 upa-portid 00000000 clock-frequency 09f3ea9a reg 000001c0 00000000 00000000 00000008 device_type cpu name SUNW,UltraSPARC -- Regards, Artyom Tarasenko solaris/sparc under qemu blog: http://tyom.blogspot.com/

1 1

[PATCH] herewrite: check for dictionary overflow
by Igor V. Kovalenko 12 Apr '10

12 Apr '10

From: Igor V. Kovalenko <igor.v.kovalenko(a)gmail.com> - add dictlimit variable to store dictionary memory size - change herewrite() to check for overflow if dictlimit is set - sparc64: set dictlimit to allocated amount Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko(a)gmail.com> --- arch/sparc64/openbios.c | 2 ++ kernel/dict.c | 1 + kernel/forth.c | 8 ++++++++ kernel/include/dict.h | 1 + 4 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/sparc64/openbios.c b/arch/sparc64/openbios.c index 2f1a955..67849e1 100644 --- a/arch/sparc64/openbios.c +++ b/arch/sparc64/openbios.c @@ -519,6 +519,8 @@ int openbios(void) collect_sys_info(&sys_info); dict = malloc(DICTIONARY_SIZE); + dictlimit = DICTIONARY_SIZE; + load_dictionary((char *)sys_info.dict_start, (unsigned long)sys_info.dict_end - (unsigned long)sys_info.dict_start); diff --git a/kernel/dict.c b/kernel/dict.c index 34b97f3..822c923 100644 --- a/kernel/dict.c +++ b/kernel/dict.c @@ -21,6 +21,7 @@ unsigned char *dict = NULL; ucell *last; cell dicthead = 0; +ucell dictlimit = 0; /* lfa2nfa * converts a link field address to a name field address, diff --git a/kernel/forth.c b/kernel/forth.c index 5fc53d3..2876709 100644 --- a/kernel/forth.c +++ b/kernel/forth.c @@ -851,6 +851,14 @@ static void herewrite(void) #ifdef CONFIG_DEBUG_INTERNAL printk("here!: new value: %x\n", tmp); #endif + + if (dictlimit && dicthead >= dictlimit) { + printk("Dictionary space overflow:" + " dicthead=" FMT_ucellx + " dictlimit=" FMT_ucellx + "\n", + dicthead, dictlimit); + } } diff --git a/kernel/include/dict.h b/kernel/include/dict.h index 7e8c320..cc30f99 100644 --- a/kernel/include/dict.h +++ b/kernel/include/dict.h @@ -50,6 +50,7 @@ extern ucell PC; extern unsigned char *dict; extern cell dicthead; +extern ucell dictlimit; extern ucell *last; #ifdef FCOMPILER extern ucell *trampoline;

3 3

[commit] r741 - in trunk/openbios-devel: arch/amd64 arch/ppc/qemu arch/sparc32 arch/sparc64 arch/unix arch/x86 include/arch/amd64 kernel kernel/include
by repository service 12 Apr '10

12 Apr '10

Author: mcayland Date: Mon Apr 12 22:02:53 2010 New Revision: 741 URL: http://tracker.coreboot.org/trac/openbios/changeset/741 Log: Commit revised version of Igor Kovalenko's patch for detecting whether dictionary allocations have overrun the memory buffer allocated for them. Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko(a)gmail.com> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/arch/amd64/openbios.c trunk/openbios-devel/arch/ppc/qemu/kernel.c trunk/openbios-devel/arch/sparc32/openbios.c trunk/openbios-devel/arch/sparc64/openbios.c trunk/openbios-devel/arch/unix/unix.c trunk/openbios-devel/arch/x86/openbios.c trunk/openbios-devel/include/arch/amd64/types.h trunk/openbios-devel/kernel/dict.c trunk/openbios-devel/kernel/forth.c trunk/openbios-devel/kernel/include/dict.h Modified: trunk/openbios-devel/arch/amd64/openbios.c ============================================================================== --- trunk/openbios-devel/arch/amd64/openbios.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/amd64/openbios.c Mon Apr 12 22:02:53 2010 (r741) @@ -19,7 +19,8 @@ void boot(void); -static char intdict[256 * 1024]; +#define DICTIONARY_SIZE (256*1024) /* 256K for the dictionary */ +static char intdict[DICTIONARY_SIZE]; static void init_memory(void) { @@ -63,6 +64,8 @@ collect_sys_info(&sys_info); dict=intdict; + dictlimit = DICTIONARY_SIZE; + load_dictionary((char *)sys_info.dict_start, sys_info.dict_end-sys_info.dict_start); Modified: trunk/openbios-devel/arch/ppc/qemu/kernel.c ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/kernel.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/ppc/qemu/kernel.c Mon Apr 12 22:02:53 2010 (r741) @@ -83,6 +83,8 @@ initialize_forth( void ) { dict = malloc(DICTIONARY_SIZE); + dictlimit = DICTIONARY_SIZE; + load_dictionary( forth_dictionary, sizeof(forth_dictionary) ); PUSH_xt( bind_noname_func(arch_of_init) ); Modified: trunk/openbios-devel/arch/sparc32/openbios.c ============================================================================== --- trunk/openbios-devel/arch/sparc32/openbios.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/sparc32/openbios.c Mon Apr 12 22:02:53 2010 (r741) @@ -185,6 +185,8 @@ collect_sys_info(&sys_info); dict = malloc(DICTIONARY_SIZE); + dictlimit = DICTIONARY_SIZE; + load_dictionary((char *)sys_info.dict_start, (unsigned long)sys_info.dict_end - (unsigned long)sys_info.dict_start); Modified: trunk/openbios-devel/arch/sparc64/openbios.c ============================================================================== --- trunk/openbios-devel/arch/sparc64/openbios.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/sparc64/openbios.c Mon Apr 12 22:02:53 2010 (r741) @@ -519,6 +519,8 @@ collect_sys_info(&sys_info); dict = malloc(DICTIONARY_SIZE); + dictlimit = DICTIONARY_SIZE; + load_dictionary((char *)sys_info.dict_start, (unsigned long)sys_info.dict_end - (unsigned long)sys_info.dict_start); Modified: trunk/openbios-devel/arch/unix/unix.c ============================================================================== --- trunk/openbios-devel/arch/unix/unix.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/unix/unix.c Mon Apr 12 22:02:53 2010 (r741) @@ -485,6 +485,7 @@ return 1; } + dictlimit = DICTIONARY_SIZE; memset(dict, 0, DICTIONARY_SIZE); if (!segfault) { Modified: trunk/openbios-devel/arch/x86/openbios.c ============================================================================== --- trunk/openbios-devel/arch/x86/openbios.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/arch/x86/openbios.c Mon Apr 12 22:02:53 2010 (r741) @@ -22,7 +22,8 @@ void boot(void); void collect_sys_info(struct sys_info *info); -static unsigned char intdict[256 * 1024]; +#define DICTIONARY_SIZE (256*1024) /* 256K for the dictionary */ +static unsigned char intdict[DICTIONARY_SIZE]; #ifdef CONFIG_DRIVER_PCI static const pci_arch_t default_pci_host = { @@ -86,6 +87,8 @@ collect_sys_info(&sys_info); dict=intdict; + dictlimit = DICTIONARY_SIZE; + load_dictionary((char *)sys_info.dict_start, (unsigned long)sys_info.dict_end - (unsigned long)sys_info.dict_start); Modified: trunk/openbios-devel/include/arch/amd64/types.h ============================================================================== --- trunk/openbios-devel/include/arch/amd64/types.h Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/include/arch/amd64/types.h Mon Apr 12 22:02:53 2010 (r741) @@ -23,6 +23,8 @@ typedef __int128_t dcell; typedef __uint128_t ducell; +#define FMT_ucellx "%016llx" + #define FMT_elf "%#x" #define bitspercell (sizeof(cell)<<3) Modified: trunk/openbios-devel/kernel/dict.c ============================================================================== --- trunk/openbios-devel/kernel/dict.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/kernel/dict.c Mon Apr 12 22:02:53 2010 (r741) @@ -21,6 +21,7 @@ unsigned char *dict = NULL; ucell *last; cell dicthead = 0; +cell dictlimit = 0; /* lfa2nfa * converts a link field address to a name field address, Modified: trunk/openbios-devel/kernel/forth.c ============================================================================== --- trunk/openbios-devel/kernel/forth.c Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/kernel/forth.c Mon Apr 12 22:02:53 2010 (r741) @@ -851,6 +851,14 @@ #ifdef CONFIG_DEBUG_INTERNAL printk("here!: new value: %x\n", tmp); #endif + + if (dictlimit && dicthead >= dictlimit) { + printk("Dictionary space overflow:" + " dicthead=" FMT_ucellx + " dictlimit=" FMT_ucellx + "\n", + dicthead, dictlimit); + } } Modified: trunk/openbios-devel/kernel/include/dict.h ============================================================================== --- trunk/openbios-devel/kernel/include/dict.h Mon Apr 12 12:03:05 2010 (r740) +++ trunk/openbios-devel/kernel/include/dict.h Mon Apr 12 22:02:53 2010 (r741) @@ -50,6 +50,7 @@ extern unsigned char *dict; extern cell dicthead; +extern cell dictlimit; extern ucell *last; #ifdef FCOMPILER extern ucell *trampoline;

1 0

[commit] r740 - trunk/openbios-devel/libopenbios
by repository service 12 Apr '10

12 Apr '10

Author: mcayland Date: Mon Apr 12 12:03:05 2010 New Revision: 740 URL: http://tracker.coreboot.org/trac/openbios/changeset/740 Log: Revert r739 since the update translations code only updates the OpenBIOS properties and not the real MMU translations. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/ofmem_common.c Modified: trunk/openbios-devel/libopenbios/ofmem_common.c ============================================================================== --- trunk/openbios-devel/libopenbios/ofmem_common.c Sat Apr 10 13:08:57 2010 (r739) +++ trunk/openbios-devel/libopenbios/ofmem_common.c Mon Apr 12 12:03:05 2010 (r740) @@ -401,6 +401,8 @@ } add_entry( phys, size, &ofmem->phys_range ); + ofmem_update_translations(); + return phys; }

1 0

memory corruption with "read" $call-method (sparc32)
by Artyom Tarasenko 11 Apr '10

11 Apr '10

Breakpoint 4, obp_devread (dev_desc=-2400864, buf=0xf00a30ec "\240", nbytes=8192) at ../arch/sparc32/romvec.c:314 314 PUSH((int)buf); (gdb) next 315 PUSH(nbytes); (gdb) next 316 push_str("read"); (gdb) next 317 PUSH(dev_desc); (gdb) next 318 fword("$call-method"); // just in case (gdb) info registers g0 0x0 0 g1 0x4c 76 g2 0xffd4f1b0 -2821712 g3 0x13 19 g4 0xffdb5da0 -2400864 g5 0x0 0 g6 0x0 0 g7 0x0 0 o0 0xffdb5da0 -2400864 o1 0x0 0 o2 0xf00a30ec -267767572 o3 0x20 32 o4 0x10 16 o5 0x0 0 sp 0x125fb0 0x125fb0 o7 0xffd05eb0 -3121488 l0 0x4401dc4 71310788 l1 0x10e6dc 1107676 l2 0x107388 1078152 l3 0x40 64 l4 0x80 128 l5 0x0 0 l6 0x0 0 l7 0x0 0 i0 0xffdb5da0 -2400864 i1 0xf00a30ec -267767572 i2 0x2000 8192 i3 0xfffffffc -4 i4 0x20 32 i5 0x10f444 1111108 fp 0x126020 0x126020 i7 0x10e88c 1108108 y 0x800 2048 psr 0x4401de4 [ #2 ET PS S #8 #10 #11 EF #22 #26 ] wim 0x40 64 tbr 0xffd00060 -3145632 pc 0xffd05eb8 0xffd05eb8 <obp_devread+80> npc 0xffd05ebc 0xffd05ebc <obp_devread+84> fsr 0x80000 [ #19 ] csr 0x0 0 // here resides Solaris's printf: (gdb) disas 0x00104798, 0x001047c0 Dump of assembler code from 0x104798 to 0x1047c0: 0x00104798: save %sp, -96, %sp 0x0010479c: st %i1, [ %fp + 0x48 ] 0x001047a0: mov %i0, %o0 0x001047a4: st %i2, [ %fp + 0x4c ] 0x001047a8: add %fp, 0x48, %o1 0x001047ac: st %i3, [ %fp + 0x50 ] 0x001047b0: st %i4, [ %fp + 0x54 ] 0x001047b4: call 0x10f4a8 0x001047b8: st %i5, [ %fp + 0x58 ] 0x001047bc: ret End of assembler dump. (gdb) next 319 ret = POP(); // Oooops, not anymore (gdb) disas 0x00104798, 0x001047c0 Dump of assembler code from 0x104798 to 0x1047c0: 0x00104798: bne,a 0x1046bc 0x0010479c: ld [ %i0 + 0x14 ], %o0 0x001047a0: ld [ %i1 + 0x10 ], %i4 0x001047a4: cmp %i4, %i2 0x001047a8: be 0x104894 0x001047ac: nop 0x001047b0: ld [ %i4 + 0x10 ], %o0 0x001047b4: call 0x1048fc 0x001047b8: nop 0x001047bc: mov %o0, %i1 End of assembler dump. reading 8192 bytes into the address 0xf00a30ec corrupts 0x00104798. Is there an easy way to see from gdb where the both addresses are mapped to? "map?" seems to be not implemented in the OpenBIOS. -- Regards, Artyom Tarasenko solaris/sparc under qemu blog: http://tyom.blogspot.com/

4 10

[commit] r739 - trunk/openbios-devel/libopenbios
by repository service 10 Apr '10

10 Apr '10

Author: mcayland Date: Sat Apr 10 13:08:57 2010 New Revision: 739 URL: http://tracker.coreboot.org/trac/openbios/changeset/739 Log: Don't try and update the MMU mappings when claiming physical memory. This is probably related to r737 and seems to solve an issue whereby Forth starts doing strange things just after attemping a claim on physical memory resource. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/ofmem_common.c Modified: trunk/openbios-devel/libopenbios/ofmem_common.c ============================================================================== --- trunk/openbios-devel/libopenbios/ofmem_common.c Thu Apr 8 23:31:44 2010 (r738) +++ trunk/openbios-devel/libopenbios/ofmem_common.c Sat Apr 10 13:08:57 2010 (r739) @@ -401,8 +401,6 @@ } add_entry( phys, size, &ofmem->phys_range ); - ofmem_update_translations(); - return phys; }

3 4

[commit] r738 - trunk/openbios-devel/libopenbios
by repository service 08 Apr '10

08 Apr '10

Author: mcayland Date: Thu Apr 8 23:31:44 2010 New Revision: 738 URL: http://tracker.coreboot.org/trac/openbios/changeset/738 Log: Slight correct to r736 so that the number of getprop arguments is correctly displayed. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/client.c Modified: trunk/openbios-devel/libopenbios/client.c ============================================================================== --- trunk/openbios-devel/libopenbios/client.c Thu Apr 8 23:22:39 2010 (r737) +++ trunk/openbios-devel/libopenbios/client.c Thu Apr 8 23:31:44 2010 (r738) @@ -170,7 +170,7 @@ } else if (strcmp(pb->service, "getproplen") == 0) { printk("0x%08lx\n", pb->args[pb->nargs]); } else if (strcmp(pb->service, "getprop") == 0) { - printk("%ld\n", pb->args[pb->nargs]); + printk("%ld\n", pb->args[3]); memdump((char*)pb->args[2], pb->args[3]); } else if (strcmp(pb->service, "nextprop") == 0) { printk("%ld\n", pb->args[pb->nargs]);

1 0