OpenBIOS April 2010

openbios@openbios.org

14 participants
65 discussions

[RFC] cross-compiler detection does not work with dash

by Andreas Färber

Hello, On Ubuntu Karmic `./config/scripts/switch-arch cross-ppc` did not recognize my powerpc-elf-gcc. The GNOME Terminal appears to use bash, where `type -p powerpc-elf-gcc && echo yah` works, but /bin/sh is dash, where it does not: echo "type -p powerpc-elf-gcc && echo yah" | /bin/sh The following change made it work. Andreas diff --git a/config/scripts/switch-arch b/config/scripts/switch-arch index c145e86..19dd877 100755 --- a/config/scripts/switch-arch +++ b/config/scripts/switch-arch @@ -88,7 +88,7 @@ select_prefix() { for TARGET in ${1}-linux-gnu- ${1}-elf- ${1}-eabi- do - if type -p ${TARGET}gcc > /dev/null + if which ${TARGET}gcc > /dev/null then return fi

10 years, 3 months

Adding words to forth - the tutorial

by Programmingkid

A while ago I posted a tutorial on how to add words to the dictionary. Has anyone done anything with it? I was hoping to see it on the OpenBIOS web site.

10 years, 3 months

Re: [OpenBIOS] Possible MMU translation bug?

by Mark Cave-Ayland

Tarl Neustaedter wrote: > My recollection (I don't have time to pursue it right now, alligators at > work) is that OpenBoot switches register sets when called by Solaris, > thus using a different set of globals. I'll try to check later. Oh wait - I think I see what it is now. On closer inspection, it seems that translate was being invoked through CIF after all (I think now the Qemu output only shows blocks being translated and not executed?). Tracing through the code, it seems like there's an off-by-one bug in the CIF parameter code which means that a subsequent stack push will overwrite the last saved parameter (which is %g7). I think I've fixed it and am testing a patch now. ATB, Mark. -- Mark Cave-Ayland - Senior Technical Architect PostgreSQL - PostGIS Sirius Corporation plc - control through freedom http://www.siriusit.co.uk t: +44 870 608 0063 Sirius Labs: http://www.siriusit.co.uk/labs

10 years, 3 months

[commit] r749 - trunk/openbios-devel/arch/sparc64

by repository service

Author: mcayland Date: Fri Apr 16 12:20:06 2010 New Revision: 749 URL: http://tracker.coreboot.org/trac/openbios/changeset/749 Log: Fix a mistake in call-client.S whereby the stack offsets were out by one item. When saving registers upon a client's entry into the CIF, we were using space for one more stack item than we had allocated. Hence a subsequent stack push would corrupt the topmost item (in this case register %g7) causing it to be restored with a random value before returning to the client. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/arch/sparc64/call-client.S Modified: trunk/openbios-devel/arch/sparc64/call-client.S ============================================================================== --- trunk/openbios-devel/arch/sparc64/call-client.S Fri Apr 16 12:01:42 2010 (r748) +++ trunk/openbios-devel/arch/sparc64/call-client.S Fri Apr 16 12:20:06 2010 (r749) @@ -21,24 +21,24 @@ flushw save %sp, -248, %sp stx %g1, [%sp + 2047 + 192 + 0] - stx %g2, [%sp + 2047 + 192 + 16] - stx %g3, [%sp + 2047 + 192 + 24] - stx %g4, [%sp + 2047 + 192 + 32] - stx %g5, [%sp + 2047 + 192 + 40] - stx %g6, [%sp + 2047 + 192 + 48] - stx %g7, [%sp + 2047 + 192 + 56] + stx %g2, [%sp + 2047 + 192 + 8] + stx %g3, [%sp + 2047 + 192 + 16] + stx %g4, [%sp + 2047 + 192 + 24] + stx %g5, [%sp + 2047 + 192 + 32] + stx %g6, [%sp + 2047 + 192 + 40] + stx %g7, [%sp + 2047 + 192 + 48] call of_client_interface mov %i0, %o0 mov %o0, %i0 ldx [%sp + 2047 + 192 + 0], %g1 - ldx [%sp + 2047 + 192 + 16], %g2 - ldx [%sp + 2047 + 192 + 24], %g3 - ldx [%sp + 2047 + 192 + 32], %g4 - ldx [%sp + 2047 + 192 + 40], %g5 - ldx [%sp + 2047 + 192 + 48], %g6 - ldx [%sp + 2047 + 192 + 56], %g7 + ldx [%sp + 2047 + 192 + 8], %g2 + ldx [%sp + 2047 + 192 + 16], %g3 + ldx [%sp + 2047 + 192 + 24], %g4 + ldx [%sp + 2047 + 192 + 32], %g5 + ldx [%sp + 2047 + 192 + 40], %g6 + ldx [%sp + 2047 + 192 + 48], %g7 return %i7+8 nop

10 years, 3 months

[commit] r748 - trunk/openbios-devel/arch/sparc64

by repository service

Author: mcayland Date: Fri Apr 16 12:01:42 2010 New Revision: 748 URL: http://tracker.coreboot.org/trac/openbios/changeset/748 Log: Increase dictionary size from 256K to 512K on SPARC64 as it is clear that on OpenSolaris we are overflowing the dictionary at runtime and corrupting OpenBIOS memory. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/arch/sparc64/ofmem_sparc64.c trunk/openbios-devel/arch/sparc64/openbios.c Modified: trunk/openbios-devel/arch/sparc64/ofmem_sparc64.c ============================================================================== --- trunk/openbios-devel/arch/sparc64/ofmem_sparc64.c Thu Apr 15 18:43:01 2010 (r747) +++ trunk/openbios-devel/arch/sparc64/ofmem_sparc64.c Fri Apr 16 12:01:42 2010 (r748) @@ -20,7 +20,7 @@ #define OF_MALLOC_BASE ((char*)OFMEM + ALIGN_SIZE(sizeof(ofmem_t), 8)) -#define MEMSIZE ((128 + 256 + 512) * 1024) +#define MEMSIZE ((128 + 512 + 512) * 1024) static union { char memory[MEMSIZE]; ofmem_t ofmem; Modified: trunk/openbios-devel/arch/sparc64/openbios.c ============================================================================== --- trunk/openbios-devel/arch/sparc64/openbios.c Thu Apr 15 18:43:01 2010 (r747) +++ trunk/openbios-devel/arch/sparc64/openbios.c Fri Apr 16 12:01:42 2010 (r748) @@ -33,7 +33,7 @@ #define APB_MEM_BASE 0x1ff00000000ULL #define MEMORY_SIZE (512*1024) /* 512K ram for hosted system */ -#define DICTIONARY_SIZE (256*1024) /* 256K for the dictionary */ +#define DICTIONARY_SIZE (512*1024) /* 512K for the dictionary */ static ucell *memory;

10 years, 3 months

Possible MMU translation bug?

by Mark Cave-Ayland

Hi all, So far Milax crashes a few seconds into executing the OpenSolaris kernel and I'm wondering if the bug is related to not preserving registers in the MMU routines. The instruction causing the crash is the following: 0x0000000001047444: ldx [ %g7 + 0xa8 ], %o2 Given that there were several instances of this exact instruction in previous nearby blocks of code, I used the qemu debugging output to see what was happening in this particular case. Comments are denoted with a ^. IN: 0x0000000001050860: call 0x1050ee8 0x0000000001050864: add %fp, 0x7a7, %o0 ^ Looks like a standard branch. %g7 is currently set to 0x180e000 -------------- IN: mmu_translate 0x00000000ffd0a788: save %sp, -224, %sp 0x00000000ffd0a78c: call 0xffd0a830 0x00000000ffd0a790: nop ^ Hmmm. But we've now invoked mmu_translate in OpenBIOS? -------------- IN: mmu_translate 0x00000000ffd0a794: mov %o0, %g1 0x00000000ffd0a798: stx %g1, [ %fp + 0x7df ] 0x00000000ffd0a79c: add %fp, 0x7d7, %g1 0x00000000ffd0a7a0: ldx [ %fp + 0x7df ], %o0 0x00000000ffd0a7a4: mov %g1, %o1 0x00000000ffd0a7a8: call 0xffd1e134 0x00000000ffd0a7ac: nop -------------- IN: ofmem_translate 0x00000000ffd1e134: save %sp, -240, %sp 0x00000000ffd1e138: stx %i0, [ %fp + 0x87f ] 0x00000000ffd1e13c: stx %i1, [ %fp + 0x887 ] 0x00000000ffd1e140: call 0xffd0e37c 0x00000000ffd1e144: nop -------------- IN: ofmem_translate 0x00000000ffd1e148: mov %o0, %g1 0x00000000ffd1e14c: stx %g1, [ %fp + 0x7d7 ] 0x00000000ffd1e150: ldx [ %fp + 0x7d7 ], %g1 0x00000000ffd1e154: ldx [ %g1 + 0x28 ], %g1 0x00000000ffd1e158: stx %g1, [ %fp + 0x7df ] 0x00000000ffd1e15c: b %xcc, 0xffd1e1d8 0x00000000ffd1e160: nop -------------- IN: ofmem_translate 0x00000000ffd1e1d8: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1dc: brz %g1, 0xffd1e1fc 0x00000000ffd1e1e0: nop -------------- IN: ofmem_translate 0x00000000ffd1e1e4: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1e8: ldx [ %g1 + 8 ], %g2 0x00000000ffd1e1ec: ldx [ %fp + 0x87f ], %g1 0x00000000ffd1e1f0: cmp %g2, %g1 0x00000000ffd1e1f4: bleu %xcc, 0xffd1e164 0x00000000ffd1e1f8: nop -------------- IN: ofmem_translate 0x00000000ffd1e164: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e168: ldx [ %g1 + 8 ], %g2 0x00000000ffd1e16c: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e170: ldx [ %g1 + 0x10 ], %g1 0x00000000ffd1e174: add %g2, %g1, %g1 0x00000000ffd1e178: add %g1, -1, %g2 0x00000000ffd1e17c: ldx [ %fp + 0x87f ], %g1 0x00000000ffd1e180: cmp %g2, %g1 0x00000000ffd1e184: bcs %xcc, 0xffd1e1cc 0x00000000ffd1e188: nop -------------- IN: ofmem_translate 0x00000000ffd1e1cc: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1d0: ldx [ %g1 ], %g1 0x00000000ffd1e1d4: stx %g1, [ %fp + 0x7df ] 0x00000000ffd1e1d8: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1dc: brz %g1, 0xffd1e1fc 0x00000000ffd1e1e0: nop -------------- IN: ofmem_translate 0x00000000ffd1e18c: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e190: ldx [ %g1 + 8 ], %g2 0x00000000ffd1e194: ldx [ %fp + 0x87f ], %g1 0x00000000ffd1e198: sub %g1, %g2, %g1 0x00000000ffd1e19c: stx %g1, [ %fp + 0x7e7 ] 0x00000000ffd1e1a0: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1a4: ldx [ %g1 + 0x20 ], %g2 0x00000000ffd1e1a8: ldx [ %fp + 0x887 ], %g1 0x00000000ffd1e1ac: stx %g2, [ %g1 ] 0x00000000ffd1e1b0: ldx [ %fp + 0x7df ], %g1 0x00000000ffd1e1b4: ldx [ %g1 + 0x18 ], %g2 0x00000000ffd1e1b8: ldx [ %fp + 0x7e7 ], %g1 0x00000000ffd1e1bc: add %g2, %g1, %g1 0x00000000ffd1e1c0: stx %g1, [ %fp + 0x7c7 ] 0x00000000ffd1e1c4: b %xcc, 0xffd1e204 0x00000000ffd1e1c8: nop -------------- IN: ofmem_translate 0x00000000ffd1e204: ldx [ %fp + 0x7c7 ], %g1 0x00000000ffd1e208: mov %g1, %i0 0x00000000ffd1e20c: rett %i7 + 8 0x00000000ffd1e210: nop -------------- IN: mmu_translate 0x00000000ffd0a7b0: mov %o0, %g1 0x00000000ffd0a7b4: stx %g1, [ %fp + 0x7e7 ] 0x00000000ffd0a7b8: ldx [ %fp + 0x7e7 ], %g1 0x00000000ffd0a7bc: cmp %g1, -1 0x00000000ffd0a7c0: be %xcc, 0xffd0a81c 0x00000000ffd0a7c4: nop -------------- IN: mmu_translate 0x00000000ffd0a7c8: ldx [ %fp + 0x7e7 ], %g2 0x00000000ffd0a7cc: mov -1, %g1 0x00000000ffd0a7d0: srlx %g1, 0x20, %g1 0x00000000ffd0a7d4: and %g2, %g1, %g1 0x00000000ffd0a7d8: mov %g1, %o0 0x00000000ffd0a7dc: call 0xffd0a4f8 0x00000000ffd0a7e0: nop -------------- IN: mmu_translate 0x00000000ffd0a7e4: ldx [ %fp + 0x7e7 ], %g1 0x00000000ffd0a7e8: srlx %g1, 0x20, %g1 0x00000000ffd0a7ec: mov %g1, %o0 0x00000000ffd0a7f0: call 0xffd0a4f8 0x00000000ffd0a7f4: nop -------------- IN: mmu_translate 0x00000000ffd0a7f8: ldx [ %fp + 0x7d7 ], %g1 0x00000000ffd0a7fc: mov %g1, %o0 0x00000000ffd0a800: call 0xffd0a4f8 0x00000000ffd0a804: nop -------------- IN: mmu_translate 0x00000000ffd0a808: mov -1, %o0 ! 0xffffffffffffffff 0x00000000ffd0a80c: call 0xffd0a4f8 0x00000000ffd0a810: nop -------------- IN: mmu_translate 0x00000000ffd0a814: b %xcc, 0xffd0a828 0x00000000ffd0a818: nop -------------- IN: mmu_translate 0x00000000ffd0a828: rett %i7 + 8 0x00000000ffd0a82c: nop -------------- IN: 0x0000000001007d54: restore %o0, %g0, %o0 -------------- IN: 0x0000000001050868: call 0x104cf7c 0x000000000105086c: mov %o0, %i5 ^ Return from mmu_translate block. %g7 is now 0x4c23549c. -------------- IN: 0x0000000001014c84: sethi %hi(0x181c800), %o5 0x0000000001014c88: mov %o7, %g1 0x0000000001014c8c: ld [ %o5 + 0x10 ], %o5 0x0000000001014c90: sra %o5, 0, %o0 0x0000000001014c94: call 0x104743c 0x0000000001014c98: mov %g1, %o7 -------------- IN: 0x000000000104743c: rdpr %pil, %o1 0x0000000001047440: wrpr 0xf, %pil 0x0000000001047444: ldx [ %g7 + 0xa8 ], %o2 0x0000000001047448: ld [ %o2 + 0x10c ], %o2 0x000000000104744c: cmp %o2, %o0 0x0000000001047450: movl %xcc, %o0, %o2 0x0000000001047454: wrpr %g0, %o2, %pil 0x0000000001047458: retl 0x000000000104745c: mov %o1, %o0 Search PC... Search PC... Search PC... Search PC... Search PC... Search PC... Search PC... Search PC... Search PC... -------------- IN: 0x000000000104743c: rdpr %pil, %o1 0x0000000001047440: wrpr 0xf, %pil 0x0000000001047444: ldx [ %g7 + 0xa8 ], %o2 ^ %g7 + 0xa8 = 0x4c235544 (throws alignment exception) I'm wondering if the issue here is that the "call 0x1050ee8" instruction is causing an MMU fault which is calling OpenBIOS's mmu_translate via a trap. Since the mmu_translate function fails to preserve the global registers (compared to the CIF interface calls) then subsequent global register access is doomed to cause failure. ATB, Mark. -- Mark Cave-Ayland - Senior Technical Architect PostgreSQL - PostGIS Sirius Corporation plc - control through freedom http://www.siriusit.co.uk t: +44 870 608 0063 Sirius Labs: http://www.siriusit.co.uk/labs

10 years, 3 months

[commit] r747 - in trunk/openbios-devel: include/libc libc

by repository service

Author: blueswirl Date: Thu Apr 15 18:43:01 2010 New Revision: 747 URL: http://tracker.coreboot.org/trac/openbios/changeset/747 Log: Remove unused memchr() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:59 2010 (r746) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:43:01 2010 (r747) @@ -43,7 +43,6 @@ extern void *memcpy(void * dest,const void *src,size_t count); extern void *memmove(void * dest,const void *src,size_t count); extern int memcmp(const void * cs,const void * ct,size_t count); -extern void *memchr(const void *s, int c, size_t n); extern char *strdup( const char *str ); extern int strcasecmp( const char *cs, const char *ct ); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:59 2010 (r746) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:43:01 2010 (r747) @@ -346,27 +346,6 @@ return res; } -/** - * memchr - Find a character in an area of memory. - * @s: The memory area - * @c: The byte to search for - * @n: The size of the area. - * - * returns the address of the first occurrence of @c, or %NULL - * if @c is not found - */ -void *memchr(const void *s, int c, size_t n) -{ - const unsigned char *p = s; - while (n-- != 0) { - if ((unsigned char)c == *p++) { - return (void *)(p-1); - } - } - return NULL; -} - - char * strdup( const char *str ) {

10 years, 3 months

[commit] r746 - in trunk/openbios-devel: include/libc libc

by repository service

Author: blueswirl Date: Thu Apr 15 18:42:59 2010 New Revision: 746 URL: http://tracker.coreboot.org/trac/openbios/changeset/746 Log: Remove unused strstr() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:56 2010 (r745) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:59 2010 (r746) @@ -43,7 +43,6 @@ extern void *memcpy(void * dest,const void *src,size_t count); extern void *memmove(void * dest,const void *src,size_t count); extern int memcmp(const void * cs,const void * ct,size_t count); -extern char *strstr(const char * s1,const char * s2); extern void *memchr(const void *s, int c, size_t n); extern char *strdup( const char *str ); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:56 2010 (r745) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:59 2010 (r746) @@ -347,28 +347,6 @@ } /** - * strstr - Find the first substring in a %NUL terminated string - * @s1: The string to be searched - * @s2: The string to search for - */ -char * strstr(const char * s1,const char * s2) -{ - int l1, l2; - - l2 = strlen(s2); - if (!l2) - return (char *) s1; - l1 = strlen(s1); - while (l1 >= l2) { - l1--; - if (!memcmp(s1,s2,l2)) - return (char *) s1; - s1++; - } - return NULL; -} - -/** * memchr - Find a character in an area of memory. * @s: The memory area * @c: The byte to search for

10 years, 3 months

[commit] r745 - in trunk/openbios-devel: include/libc libc

by repository service

Author: blueswirl Date: Thu Apr 15 18:42:56 2010 New Revision: 745 URL: http://tracker.coreboot.org/trac/openbios/changeset/745 Log: Remove unused memscan() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:54 2010 (r744) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:56 2010 (r745) @@ -43,7 +43,6 @@ extern void *memcpy(void * dest,const void *src,size_t count); extern void *memmove(void * dest,const void *src,size_t count); extern int memcmp(const void * cs,const void * ct,size_t count); -extern void *memscan(void * addr, int c, size_t size); extern char *strstr(const char * s1,const char * s2); extern void *memchr(const void *s, int c, size_t n); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:54 2010 (r744) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:56 2010 (r745) @@ -347,28 +347,6 @@ } /** - * memscan - Find a character in an area of memory. - * @addr: The memory area - * @c: The byte to search for - * @size: The size of the area. - * - * returns the address of the first occurrence of @c, or 1 byte past - * the area if @c is not found - */ -void * memscan(void * addr, int c, size_t size) -{ - unsigned char * p = (unsigned char *) addr; - - while (size) { - if (*p == c) - return (void *) p; - p++; - size--; - } - return (void *) p; -} - -/** * strstr - Find the first substring in a %NUL terminated string * @s1: The string to be searched * @s2: The string to search for

10 years, 3 months

[commit] r744 - in trunk/openbios-devel: include/libc libc

by repository service

Author: blueswirl Date: Thu Apr 15 18:42:54 2010 New Revision: 744 URL: http://tracker.coreboot.org/trac/openbios/changeset/744 Log: Remove unused bcopy() Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/include/libc/string.h trunk/openbios-devel/libc/string.c Modified: trunk/openbios-devel/include/libc/string.h ============================================================================== --- trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:51 2010 (r743) +++ trunk/openbios-devel/include/libc/string.h Thu Apr 15 18:42:54 2010 (r744) @@ -40,7 +40,6 @@ extern char *strpbrk(const char * cs,const char * ct); extern char *strsep(char **s, const char *ct); extern void *memset(void * s,int c,size_t count); -extern char *bcopy(const char * src, char * dest, int count); extern void *memcpy(void * dest,const void *src,size_t count); extern void *memmove(void * dest,const void *src,size_t count); extern int memcmp(const void * cs,const void * ct,size_t count); Modified: trunk/openbios-devel/libc/string.c ============================================================================== --- trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:51 2010 (r743) +++ trunk/openbios-devel/libc/string.c Thu Apr 15 18:42:54 2010 (r744) @@ -283,28 +283,6 @@ } /** - * bcopy - Copy one area of memory to another - * @src: Where to copy from - * @dest: Where to copy to - * @count: The size of the area. - * - * Note that this is the same as memcpy(), with the arguments reversed. - * memcpy() is the standard, bcopy() is a legacy BSD function. - * - * You should not use this function to access IO space, use memcpy_toio() - * or memcpy_fromio() instead. - */ -char * bcopy(const char * src, char * dest, int count) -{ - char *tmp = dest; - - while (count--) - *tmp++ = *src++; - - return dest; -} - -/** * memcpy - Copy one area of memory to another * @dest: Where to copy to * @src: Where to copy from

10 years, 3 months