OpenBIOS
Threads by month
- ----- 2025 -----
- July
- June
- May
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1997 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1996 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1995 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1994 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1993 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1992 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1991 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1990 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1989 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1988 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1987 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1986 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1985 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1984 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1983 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1982 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1981 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1980 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1979 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1978 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1977 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1976 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1975 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1974 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1973 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1972 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1971 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1970 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1969 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1968 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1967 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1966 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1965 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1964 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1963 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1962 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1961 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1960 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1959 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1958 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1957 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1956 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1955 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1954 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1953 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1952 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1951 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1950 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1949 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1948 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1947 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1946 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1945 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1944 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1943 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1942 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1941 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1940 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1939 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1938 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1937 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1936 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1935 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1934 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1933 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1932 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1931 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1930 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1929 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1928 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1927 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1926 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1925 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1924 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1923 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1922 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1921 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1920 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1919 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1918 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1917 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1916 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1915 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1914 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1913 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1912 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1911 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1910 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1909 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1908 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1907 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1906 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1905 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1904 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
April 2007
- 9 participants
- 56 discussions
Author: stepan
Date: 2007-04-09 14:19:41 +0200 (Mon, 09 Apr 2007)
New Revision: 119
Modified:
openbios-devel/drivers/obio.c
Log:
fix from blueswirl
Modified: openbios-devel/drivers/obio.c
===================================================================
--- openbios-devel/drivers/obio.c 2007-04-09 12:17:51 UTC (rev 118)
+++ openbios-devel/drivers/obio.c 2007-04-09 12:19:41 UTC (rev 119)
@@ -341,7 +341,8 @@
kernel_image = nv_info.kernel_image;
kernel_size = nv_info.kernel_size;
size = nv_info.cmdline_size;
- if (size > OBIO_CMDLINE_MAX) size = OBIO_CMDLINE_MAX;
+ if (size > OBIO_CMDLINE_MAX - 1)
+ size = OBIO_CMDLINE_MAX - 1;
memcpy(obio_cmdline, nv_info.cmdline, size);
obio_cmdline[size] = '\0';
cmdline = obio_cmdline;
1
0
Hi I was having a problem compiling openbios on the lastest debian release.
I thought it may have been a problem with the xsltproc version in
debian... however the debian maintainer Mike Hommey tells me that the
issue is in the openbios code. He has generated a patch which I am
forwarding (attached) which he tells me fixes the openbios XSLT.
Regards
Alex Owen
---------- Forwarded message ----------
From: Mike Hommey <mh(a)glandium.org>
Date: 08-Apr-2007 17:02
Subject: Re: Bug#401337: test case for error "Unexpected XSLT element 'param'"
To: Alex Owen <r.alex.owen(a)gmail.com>, 401337-done(a)bugs.debian.org
Cc: Nicolas Haller <nicolas(a)boiteameuh.org>
On Fri, Feb 23, 2007 at 09:32:48PM +0000, Alex Owen
<r.alex.owen(a)gmail.com> wrote:
> Sorry missed a line:
>
> >mkdir /var/tmp/testcase
> >cd /var/tmp/testcase
> >svn co svn://openbios.org/openbios/openbios-devel -r 113
> >cd openbios-devel
> config/scripts/switch-arch x86
> >make xml
> >###output starts###
> >Cleaning up... ok
> >Initializing build tree...ok.
> >Creating target Makefile...warning: failed to load external entity
> >"rules.xml"
> >runtime error: file config/xml/dictionary.xsl line 13 element param
> >Unexpected XSLT element 'param'.
> >runtime error: file config/xml/dictionary.xsl line 22 element if
> >Variable 'conditions' has not been declared.
> >make: *** [xml] Error 10
> >###output ends###
Okay, I have been able to reproduce the bug... and it's not a bug.
The reason why it didn't fail before is that previous versions of
libxslt were lax on xsl:param. You are using xsl:param where
xsl:variable is to be used. xsl:param can only be top-level or a direct
child of an xsl:template.
Attached here is a diff to fix openbios-devel's xsl stylesheet. With
this patch applied, it works with xsltproc from etch.
Mike
2
1
Author: stepan
Date: 2007-04-09 14:17:51 +0200 (Mon, 09 Apr 2007)
New Revision: 118
Modified:
openbios-devel/config/xml/dictionary.xsl
openbios-devel/config/xml/object.xsl
openbios-devel/config/xml/util.xsl
Log:
fixes for xslt sheets from Mike Hommey <mh(a)glandium.org>,
reported by Alex Owen <r.alex.owen(a)gmail.com>
Modified: openbios-devel/config/xml/dictionary.xsl
===================================================================
--- openbios-devel/config/xml/dictionary.xsl 2007-04-07 09:37:28 UTC (rev 117)
+++ openbios-devel/config/xml/dictionary.xsl 2007-04-09 12:17:51 UTC (rev 118)
@@ -10,14 +10,14 @@
<xsl:for-each select="//dictionary">
<xsl:sort select="@name"/>
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions = 0">
@@ -31,26 +31,26 @@
<!-- Add all forth source files to their dictionaries -->
<xsl:for-each select="//dictionary/object">
- <xsl:param name="path">
+ <xsl:variable name="path">
<xsl:for-each select="ancestor::build">
<xsl:call-template name="get-dirname">
<xsl:with-param select="@base" name="path"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
- <xsl:param name="dictname">
+ <xsl:variable name="dictname">
<xsl:value-of select="parent::*/@name"/>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
<xsl:value-of select="$dictname"/><xsl:text>-DICTIONARY:=$(</xsl:text>
@@ -68,22 +68,22 @@
<xsl:for-each select="//dictionary">
<xsl:sort select="@name"/>
- <xsl:param name="outer-conditions">
+ <xsl:variable name="outer-conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$outer-conditions = 0">
<xsl:if test="not(preceding::dictionary/@name = @name)">
- <xsl:param name="name"><xsl:value-of select="@name"/></xsl:param>
- <xsl:param name="init">
+ <xsl:variable name="name"><xsl:value-of select="@name"/></xsl:variable>
+ <xsl:variable name="init">
<xsl:value-of select="(//dictionary[@name=$name]/attribute::init)[last()]"/>
- </xsl:param>
+ </xsl:variable>
<!-- dictionary name and dependencies -->
<xsl:text>$(ODIR)/</xsl:text>
<xsl:value-of select="@name"/><xsl:text>.dict: $(</xsl:text>
@@ -97,22 +97,22 @@
<xsl:text>	$(ODIR)/forthstrap</xsl:text>
<xsl:for-each select="//dictionary[@name = @name]">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
- <xsl:param name="path">
+ <xsl:variable name="path">
<xsl:for-each select="ancestor::build">
<xsl:call-template name="get-dirname">
<xsl:with-param select="@base" name="path"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions = 0">
<xsl:text> -I</xsl:text>
@@ -139,14 +139,14 @@
<xsl:for-each select="//dictionary">
<xsl:sort select="@name"/>
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions = 0">
Modified: openbios-devel/config/xml/object.xsl
===================================================================
--- openbios-devel/config/xml/object.xsl 2007-04-07 09:37:28 UTC (rev 117)
+++ openbios-devel/config/xml/object.xsl 2007-04-09 12:17:51 UTC (rev 118)
@@ -24,22 +24,22 @@
<!-- create rules for all compile objects -->
<xsl:for-each select="//object[(ancestor-or-self::*)[@target = $target]]">
- <xsl:param name="path">
+ <xsl:variable name="path">
<xsl:for-each select="ancestor::build">
<xsl:call-template name="get-dirname">
<xsl:with-param select="@base" name="path"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
@@ -78,14 +78,14 @@
<!-- Create linker targets for all executables -->
<xsl:for-each select="//executable">
- <xsl:param name="outer-conditions">
+ <xsl:variable name="outer-conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$outer-conditions = 0">
<xsl:if test="(ancestor-or-self::*)[@target = $target]">
@@ -98,24 +98,24 @@
<!-- add all objects -->
<xsl:for-each select="object">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
- <xsl:param name="path">
+ <xsl:variable name="path">
<xsl:for-each select="ancestor::build">
<xsl:call-template name="get-dirname">
<xsl:with-param select="@base" name="path"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:text> $(ODIR)/</xsl:text>
<xsl:value-of select="$target"/>
@@ -130,14 +130,14 @@
<!-- external objects last -->
<xsl:for-each select="external-object">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
<xsl:text> $(ODIR)/</xsl:text>
@@ -166,14 +166,14 @@
<xsl:for-each select="//library">
<xsl:sort select="@name"/>
- <xsl:param name="outer-conditions">
+ <xsl:variable name="outer-conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$outer-conditions = 0">
@@ -196,29 +196,29 @@
</xsl:choose>
<xsl:text>: </xsl:text>
- <xsl:param name="name"><xsl:value-of select="@name"/></xsl:param>
+ <xsl:variable name="name"><xsl:value-of select="@name"/></xsl:variable>
<!-- enumerate all objects for library target -->
<xsl:for-each select="//library[@name=$name]/object">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
- <xsl:param name="path">
+ <xsl:variable name="path">
<xsl:for-each select="ancestor::build">
<xsl:call-template name="get-dirname">
<xsl:with-param select="@base" name="path"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:text>$(ODIR)/</xsl:text>
<xsl:value-of select="$target"/>
@@ -234,14 +234,14 @@
<!-- external objects last -->
<xsl:for-each select="external-object">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
<xsl:text> $(ODIR)/</xsl:text>
@@ -267,14 +267,14 @@
<xsl:for-each select="//library">
<xsl:if test="object[(ancestor-or-self::*)[@target = $target]]">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
<xsl:text> $(ODIR)/</xsl:text>
<xsl:text>lib</xsl:text>
@@ -300,14 +300,14 @@
<xsl:for-each select="//executable">
<xsl:if test="(ancestor-or-self::*)[@target = $target]">
- <xsl:param name="conditions">
+ <xsl:variable name="conditions">
<xsl:text>0</xsl:text>
<xsl:for-each select="(ancestor-or-self::*)[@condition!='']">
<xsl:call-template name="resolve-condition">
<xsl:with-param select="@condition" name="expression"/>
</xsl:call-template>
</xsl:for-each>
- </xsl:param>
+ </xsl:variable>
<xsl:if test="$conditions=0">
<xsl:text> $(ODIR)/</xsl:text>
<xsl:value-of select="@name"/>
Modified: openbios-devel/config/xml/util.xsl
===================================================================
--- openbios-devel/config/xml/util.xsl 2007-04-07 09:37:28 UTC (rev 117)
+++ openbios-devel/config/xml/util.xsl 2007-04-09 12:17:51 UTC (rev 118)
@@ -44,8 +44,8 @@
<xsl:choose>
<xsl:when test="$expression!=''">
- <xsl:param name="value"><xsl:value-of select="document('../../config.xml')//option[@name=$confexpr]/attribute::value"/></xsl:param>
- <xsl:param name="type"><xsl:value-of select="document('../../config.xml')//option[@name=$confexpr]/attribute::type"/></xsl:param>
+ <xsl:variable name="value"><xsl:value-of select="document('../../config.xml')//option[@name=$confexpr]/attribute::value"/></xsl:variable>
+ <xsl:variable name="type"><xsl:value-of select="document('../../config.xml')//option[@name=$confexpr]/attribute::type"/></xsl:variable>
<xsl:choose>
<xsl:when test="$type='boolean'">
<xsl:choose>
1
0
> if (size > OBIO_CMDLINE_MAX) size = OBIO_CMDLINE_MAX;
> memcpy(obio_cmdline, nv_info.cmdline, size);
> - obio_cmdline[size-1] = '\0';
> + obio_cmdline[size] = '\0';
Looks like you need to change the declaration of
"obio_cmdline[]" or the maximum value "size" is
clamped to, as well?
Segher
1
0
Author: stepan
Date: 2007-04-07 11:37:28 +0200 (Sat, 07 Apr 2007)
New Revision: 117
Modified:
openbios-devel/drivers/obio.c
Log:
boot fix from blueswirl.
Modified: openbios-devel/drivers/obio.c
===================================================================
--- openbios-devel/drivers/obio.c 2007-03-23 17:00:01 UTC (rev 116)
+++ openbios-devel/drivers/obio.c 2007-04-07 09:37:28 UTC (rev 117)
@@ -340,11 +340,10 @@
}
kernel_image = nv_info.kernel_image;
kernel_size = nv_info.kernel_size;
-
- size = cmdline_size;
+ size = nv_info.cmdline_size;
if (size > OBIO_CMDLINE_MAX) size = OBIO_CMDLINE_MAX;
memcpy(obio_cmdline, nv_info.cmdline, size);
- obio_cmdline[size-1] = '\0';
+ obio_cmdline[size] = '\0';
cmdline = obio_cmdline;
cmdline_size = size;
1
0
Hi,
Current version can't boot the test images from Qemu, because the command
line is truncated. Boot is fixed with the attached patch, please apply.
_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar - get it now!
http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/
1
0