Re: [OpenBIOS] [PATCH] ppc: add Apple copyright string

[Programmingkid]

On May 22, 2015, at 5:01 PM, Cormac O'Brien wrote:
> Not really anything, but it's not an accurate representation of the real copyright and could be misleading.

Then it sounds like the original patch is good enough. Not too many people are going to be looking thru some node for a copyright message when they could just read the license agreement instead.
> On May 22, 2015 3:36 PM, "Programmingkid"  wrote:
>
> On May 22, 2015, at 4:48 AM, Mark Cave-Ayland wrote:
> > On 21/05/15 23:37, Alexander Graf wrote:
> > > On 21.05.15 19:44, Cormac O'Brien wrote:
> > > > On 21.05.15 12:18, Alexander Graf wrote:
> > > > > This requires at least a comment saying that the copyright isn't actually on Apple's side.
> > > >
> > > > Any legal things to be aware of here?
> > > > > Also, how much of that do they verify?
> > > >
> > > > As best I can tell, it verifies all of "Copyright 1983-2001 Apple
> > > > Computer, Inc.", but it looks like I can add just about anything on
> > > > the end. Suggestions?
> > >
> > > How about "Copyright 1983-2001 Apple Computer, Inc. THIS STRING IS ONLY
> > > HERE BECAUSE OF MAC OS 9 COMPATIBILITY, COPYRIGHT IS WITH THE OPENBIOS
> > > PROJECT AND ITS CONTRIBUTORS".
> >
> > We could also try some evil client detection - if we know that only
> > MacOS uses the adler32 word, we could patch it to also update the
> > copyright string at the root node of the device tree which won't be
> > user-visible from Forth as the bootloader has already executed ;)
>
> What is the worst thing that could happen if we just left this string in memory?

[PATCH] ppc: add Apple copyright string

[Mark Cave-Ayland]

On 22/05/15 22:38, Programmingkid wrote:
> On May 22, 2015, at 5:01 PM, Cormac O'Brien wrote:
> > Not really anything, but it's not an accurate representation of the
> > real copyright and could be misleading.
>
> Then it sounds like the original patch is good enough. Not too many
> people are going to be looking thru some node for a copyright message
> when they could just read the license agreement instead.

I have to side with Cormac on this one. My concern would be that someone
is distributing openbios-ppc in custom hardware outside of QEMU/OpenBIOS
where things become murkier. At least here I can see the difference in
intent between declaring an incorrect copyright string and injecting a
dummy value in order to satisfy a particular client.

ATB,

Mark.