j
: Next unread message k
: Previous unread message j a
: Jump to all threads
j l
: Jump to MailingList overview
Author: mcayland Date: Sat May 1 14:13:16 2010 New Revision: 765 URL: http://tracker.coreboot.org/trac/openbios/changeset/765
Log: Demote the 'byte-load: stack overflow' message so that it only appears when fcode-debug? is set to true. This is because the stack is automatically corrected anyway, and is triggered by a bug in older versions of the OpenSolaris boot blocks. See the following for more information:
http://src.opensolaris.org/source/history/onnv/onnv-gate/usr/src/psm/stand/b... (rev 9941:eb1c075cb0e4) http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6803195
Anyone developing new Fcode under OpenBIOS is extremely likely to want fcode-debug? enabled during development, so this seems like a reasonable compromise.
Signed-off-by: Mark Cave-Ayland mark.cave-ayland@siriusit.co.uk
Modified: trunk/openbios-devel/forth/device/feval.fs
Modified: trunk/openbios-devel/forth/device/feval.fs ============================================================================== --- trunk/openbios-devel/forth/device/feval.fs Sat May 1 11:48:57 2010 (r764) +++ trunk/openbios-devel/forth/device/feval.fs Sat May 1 14:13:16 2010 (r765) @@ -76,8 +76,10 @@ cr ." byte-load: exception caught!" cr then
- depth r@ <> if - cr ." byte-load: stack overflow, diff " depth r@ - . cr + s" fcode-debug?" evaluate if + depth r@ <> if + cr ." byte-load: warning stack overflow, diff " depth r@ - . cr + then then
r> depth! 3drop 3drop