j
: Next unread message k
: Previous unread message j a
: Jump to all threads
j l
: Jump to MailingList overview
Author: agraf Date: Fri Jun 17 02:55:04 2011 New Revision: 1044 URL: http://tracker.coreboot.org/trac/openbios/changeset/1044
Log: ppc: only clear MSR_SF when clearing high MSR bits
We are pretty aggressive now with how we clear the high MSR bits, clearing all of them when we find a 64-bit CPU.
As Segher points out, this is not always a good idea though. There might be bits set that can be crucial for operation. Hence we should only clear MSR_SF, as that's the bit we're interested in.
Reported-by: Segher Boessenkool segher@kernel.crashing.org Signed-off-by: Alexander Graf agraf@suse.de
Modified: trunk/openbios-devel/arch/ppc/qemu/start.S
Modified: trunk/openbios-devel/arch/ppc/qemu/start.S ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/start.S Fri Jun 17 02:55:02 2011 (r1043) +++ trunk/openbios-devel/arch/ppc/qemu/start.S Fri Jun 17 02:55:04 2011 (r1044) @@ -44,7 +44,7 @@ beq 1f; \ \ mfmsr r1 ; /* unset MSR_SF */ \ - clrlwi r1,r1,0 ; \ + clrldi r1,r1,1 ; \ mtmsrd r1 ; \ 1: \ mfsprg0 r1 ; /* exception stack in sprg0 */ \