[commit] r703 - in trunk/openbios-devel/arch: amd64 x86

[repository service]

Author: mcayland
Date: Wed Mar 17 23:20:12 2010
New Revision: 703
URL: http://tracker.coreboot.org/trac/openbios/changeset/703

Log:
Change the location of the function prototype for collect_sys_info() so that it both works for x86 and is the same location as 
for the amd64 build.

Signed-off-by: Mark Cave-Ayland

Modified:
   trunk/openbios-devel/arch/amd64/openbios.c
   trunk/openbios-devel/arch/amd64/sys_info.c
   trunk/openbios-devel/arch/x86/sys_info.c

Modified: trunk/openbios-devel/arch/amd64/openbios.c
==============================================================================
--- trunk/openbios-devel/arch/amd64/openbios.c	Sun Mar 14 22:40:22 2010	(r702)
+++ trunk/openbios-devel/arch/amd64/openbios.c	Wed Mar 17 23:20:12 2010	(r703)
@@ -17,7 +17,6 @@
 #include "relocate.h"

void boot(void);
-void collect_sys_info(struct sys_info *info);

static char intdict[256 * 1024];

Modified: trunk/openbios-devel/arch/amd64/sys_info.c
==============================================================================
--- trunk/openbios-devel/arch/amd64/sys_info.c	Sun Mar 14 22:40:22 2010	(r702)
+++ trunk/openbios-devel/arch/amd64/sys_info.c	Wed Mar 17 23:20:12 2010	(r703)
@@ -11,6 +11,7 @@
 #endif

void collect_multiboot_info(struct sys_info *);
+void collect_sys_info(struct sys_info *info);

void collect_sys_info(struct sys_info *info)
 {

Modified: trunk/openbios-devel/arch/x86/sys_info.c
==============================================================================
--- trunk/openbios-devel/arch/x86/sys_info.c	Sun Mar 14 22:40:22 2010	(r702)
+++ trunk/openbios-devel/arch/x86/sys_info.c	Wed Mar 17 23:20:12 2010	(r703)
@@ -10,6 +10,7 @@
 #endif

void collect_multiboot_info(struct sys_info *);
+void collect_sys_info(struct sys_info *info);

void collect_sys_info(struct sys_info *info)
 {

[Stefan Reinauer]

On 3/17/10 11:20 PM, repository service wrote:
> Author: mcayland
> Date: Wed Mar 17 23:20:12 2010
> New Revision: 703
> URL: http://tracker.coreboot.org/trac/openbios/changeset/703
>
> Log:
> Change the location of the function prototype for collect_sys_info() so that it both works for x86 and is the same location as 
> for the amd64 build.
>
> Signed-off-by: Mark Cave-Ayland

Shouldn't that go into a header file instead, and that header file be
included in both the providing and the consuming source file?

If it's just about the warning, it might be better to use
-Wno-missing-prototypes instead of artificially working around the warning..

Stefan

[Mark Cave-Ayland]

Stefan Reinauer wrote:
> Shouldn't that go into a header file instead, and that header file be
> included in both the providing and the consuming source file?

Yes, in an ideal world of course. I did a lot of untangling of the 
header files in the main source tree last weekend, but I am still 
looking at how the arch/ tree works. But it's worth putting in there at 
the moment to avoid breaking the build while we decide what to do.
> If it's just about the warning, it might be better to use
> -Wno-missing-prototypes instead of artificially working around the warning..

Possibly, although I actually found it quite helpful for working out the 
structure of the header files. It really helps show the interfaces at 
different levels and thus define how everything hangs together.

ATB,

Mark.