Re: [OpenBIOS] r502 - trunk/openbios-devel/forth/bootstrap

[Stefan Reinauer]

On 06.06.2009 16:57 Uhr, [e-mail] wrote:
> Author: blueswirl
> Date: 2009-06-06 16:57:25 +0200 (Sat, 06 Jun 2009)
> New Revision: 502
>
> Modified:
>    trunk/openbios-devel/forth/bootstrap/bootstrap.fs
> Log:
> Don't add padding spaces when evaluating headerless words (Mark Cave-Ayland)
> Modified: trunk/openbios-devel/forth/bootstrap/bootstrap.fs
>
> --- trunk/openbios-devel/forth/bootstrap/bootstrap.fs	2009-06-06 09:58:11 UTC (rev 501)
> +++ trunk/openbios-devel/forth/bootstrap/bootstrap.fs	2009-06-06 14:57:25 UTC (rev 502)
> @@ -1073,7 +1073,14 @@
>    begin @ 
>      ?dup while
>      dup lfa2name
> type space
> \ Don't print spaces for headerless words
> dup if
>  type space
> else
>  type
> then

Since the second type does nothing, this could also be written as

?dup if
  type space
else
  drop
then

It's at most a cosmetical difference though
> repeat
>    cr
>    ;

r502 - trunk/openbios-devel/forth/bootstrap

[Mark Cave-Ayland]

Stefan Reinauer wrote:
> Since the second type does nothing, this could also be written as
>
> ?dup if
>   type space
> else
>   drop
> then
>
> It's at most a cosmetical difference though

Yeah. I realised that there were multiple ways of doing this, although 
maintaining "type" seemed to be retain the most clarity. BTW shouldn't 
that drop be 2drop to account for address and length?

ATB,

Mark.