[PATCH] Fixes for Makefile clean target

[Andreas Färber]

Hello,

Here are two fixes for Makefile.target:

1) Lots of .o files stay around after a `make clean`, on Mac OS X host.

diff --git a/Makefile.target b/Makefile.target
index aa45120..8a706b2 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -62,7 +62,7 @@ info:
  clean:
    @printf "Cleaning up for $(ARCH)..."
    @rm -rf forth.dict.core forthstrap *.dict openbios-*
-	@find . -type f -name "*~" -o -name '*.o' -o -name '*.a' -exec rm \ 
{} ;
+	@find . -type f ( -name "*~" -o -name '*.o' -o -name '*.a' ) -exec  
rm {} ;
    @echo " ok"

Without this grouping, `find` fails to exec anything.

2) Even with the `find` expression fixed, the two generated files with  
the date are not removed, so take care of that manually:

diff --git a/Makefile.target b/Makefile.target
index 8a706b2..bab5998 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -62,6 +62,7 @@ info:
  clean:
    @printf "Cleaning up for $(ARCH)..."
    @rm -rf forth.dict.core forthstrap *.dict openbios-*
+	@rm -f $(ODIR)/target/include/openbios-version.h $(ODIR)/forth/ 
version.fs
    @find . -type f ( -name "*~" -o -name '*.o' -o -name '*.a' ) - 
exec rm {} ;
    @echo " ok"

Signed-off-by: Andreas Faerber

Regards,
Andreas

[Blue Swirl]

Thanks, applied both.

On Sat, May 22, 2010 at 12:54 PM, Andreas Färber  wrote:
> Hello,
>
> Here are two fixes for Makefile.target:
> Lots of .o files stay around after a `make clean`, on Mac OS X host.
>
> diff --git a/Makefile.target b/Makefile.target
> index aa45120..8a706b2 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -62,7 +62,7 @@ info:
>  clean:
>        @printf "Cleaning up for $(ARCH)..."
>        @rm -rf forth.dict.core forthstrap *.dict openbios-*
> @find . -type f -name "*~" -o -name '*.o' -o -name '*.a' -exec rm
>
> {} ;
> @find . -type f ( -name "*~" -o -name '*.o' -o -name '*.a' ) -exec
>
> rm {} ;
>        @echo " ok"
>
> Without this grouping, `find` fails to exec anything.
> Even with the `find` expression fixed, the two generated files with the
>
> date are not removed, so take care of that manually:
>
> diff --git a/Makefile.target b/Makefile.target
> index 8a706b2..bab5998 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -62,6 +62,7 @@ info:
>  clean:
>        @printf "Cleaning up for $(ARCH)..."
>        @rm -rf forth.dict.core forthstrap *.dict openbios-*
> @rm -f $(ODIR)/target/include/openbios-version.h
>
> $(ODIR)/forth/version.fs
>        @find . -type f ( -name "*~" -o -name '*.o' -o -name '*.a' ) -exec
> rm {} ;
>        @echo " ok"
>
> Signed-off-by: Andreas Faerber
>
> Regards,
> Andreas