Re: [OpenBIOS] [PATCH] arch/ppc/qemu: Rename root node for Macs to match Apple

[BALATON Zoltan]

On  6, Jun 2014 Alexander Graf wrote:
> > > /* Apple calls the root node device-tree */
> > > if (is_apple()) {
> > >    push_str("device-tree");
> > >    fword("device-name");
> > > }
> > > switch(machine_id) {
> > > case ARCH_HEATHROW:    /* OldWorld */
> >
> > I think for this I'd still prefer to change the default for all PPC
> > trees in arch/ppc/qemu/tree.fs... Alex/Andreas?
>
> Works for me :).

Should I send another version or can you add these two lines without the 
if around them? I've added the check based on this review comment:
http://www.openfirmware.info/pipermail/openbios/2014-March/008205.html

Regards,
BALATON Zoltan

[PATCH] arch/ppc/qemu: Rename root node for Macs to match Apple

[Mark Cave-Ayland]

On 06/06/14 00:29, BALATON Zoltan wrote:
> On  6, Jun 2014 Alexander Graf wrote:
> > > > /* Apple calls the root node device-tree */
> > > > if (is_apple()) {
> > > >    push_str("device-tree");
> > > >    fword("device-name");
> > > > }
> > > > switch(machine_id) {
> > > > case ARCH_HEATHROW:    /* OldWorld */
> > >
> > > I think for this I'd still prefer to change the default for all PPC
> > > trees in arch/ppc/qemu/tree.fs... Alex/Andreas?
> >
> > Works for me :).
>
> Should I send another version or can you add these two lines without the
> if around them? I've added the check based on this review comment:
> http://www.openfirmware.info/pipermail/openbios/2014-March/008205.html

I think you did this on an early version of your patch, so I'll pick it 
up from there and apply (probably later this evening).

ATB,

Mark.