Re: [OpenBIOS] [PATCH 00/16] Switch to standards-compliant Forth console from C console

[Mark Cave-Ayland]

On 10/03/13 20:52, Blue Swirl wrote:
> I used the following to fix the warning, please squash into patch #5:
>
> diff --git a/include/libopenbios/video.h b/include/libopenbios/video.h
> index 13bf143..1840981 100644
> --- a/include/libopenbios/video.h
> +++ b/include/libopenbios/video.h
> @@ -17,7 +17,7 @@ typedef struct osi_fb_info {
>       int rb, w, h, depth;
>   } osi_fb_info_t;
>
> -struct {
> +extern struct video_info {
>          int             has_video;
>          osi_fb_info_t   fb;
>          unsigned long   *pal;           /* 256 elements */
> diff --git a/libopenbios/video_common.c b/libopenbios/video_common.c
> index 11aeec7..621f032 100644
> --- a/libopenbios/video_common.c
> +++ b/libopenbios/video_common.c
> @@ -23,6 +23,7 @@
>   #include "packages/video.h"
>   #include "drivers/vga.h"
>
> +struct video_info video;
>
> unsigned long
>   get_color( int col_ind )

Thanks - I will do that.
> It looks like Forth version is a bit too buggy, for example
> 1b emit ." [H"
> should position cursor to top left corner of the screen (like HEAD),
> but with the patch set it does nothing except leaves a stray '0' on
> the stack!

Thanks for the hint - I think that it should be fairly easy to fix (I 
temporarily force debugger output to the serial port when working on the 
video routines). I'm quite tempted to make this a permanent behaviour 
when CONFIG_DEBUG_VIDEO_CONSOLE is enabled, and change the default to 
"false" so that this becomes a developer option.

ATB,

Mark.