Re: [OpenBIOS] r255 - in openbios-devel: arch/ppc/qemu include/openbios modules

[Blue Swirl]

On 11/25/08, Blue Swirl  wrote:
> On 11/25/08, Laurent Vivier  wrote:
> > Le 25 nov. 08 à 17:40, Blue Swirl a écrit :
> > > On 11/25/08, Laurent Vivier  wrote:
> > > > Le lundi 24 novembre 2008 à 18:59 +0200, Blue Swirl a écrit :
> > > > > On 11/24/08, [e-mail]  wrote:
> > > > > > Author: stepan
> > > > > > Date: 2008-11-24 13:21:36 +0100 (Mon, 24 Nov 2008)
> > > > > > New Revision: 255
> > > > > > void
> > > > > > -nvram_init( void )
> > > > > > +nvram_init( char *path )
> > > > >
> > > > > Bad idea, this breaks Sparc32 build.
> > > >
> > > > I've looked in the device tree of sparc32 and didn't find any entry for
> > > > nvram, so is the call to nvram_init() really needed ???
> > >
> > > Yes, not for registering it to the device tree, but for reading the
> > > config from nvram. The same applies to Sparc64.
> > >
> > > The function could be changed to check for a NULL (passed to it by
> > > Sparc32/64) and perform different actions then, or maybe nvconf_init
> > > should be exported and Sparc changed to use it instead of nvram_init.
> >
> > IMHO the best thing to fo is to export and call nvconf_init.
>
> OK, I'm testing the attached patch.

Committed as r262.

r255 - in openbios-devel: arch/ppc/qemu include/openbios modules

[Laurent Vivier]

Le 25 nov. 08 à 19:31, Blue Swirl a écrit :
> > [...]
>
> Committed as r262.

Thank you.
Could you commit the attached patch ?

It adds some debug macros and correct nvram_init() call for other PPC  
architectures.

Laurent
-------------------- [e-mail] --------------------
"Tout ce qui est impossible reste à accomplir"    Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard

r255 - in openbios-devel: arch/ppc/qemu include/openbios modules

[Blue Swirl]

On 11/25/08, Laurent Vivier  wrote:
> Le 25 nov. 08 à 19:31, Blue Swirl a écrit :
> > > [...]
> >
> > Committed as r262.
>
> Thank you.
>  Could you commit the attached patch ?
>
> It adds some debug macros and correct nvram_init() call for other PPC
> architectures.

Ok. I'll run some tests first.

r255 - in openbios-devel: arch/ppc/qemu include/openbios modules

[Blue Swirl]

On 11/25/08, Laurent Vivier  wrote:
> Le 25 nov. 08 à 19:31, Blue Swirl a écrit :
> > > [...]
> >
> > Committed as r262.
>
> Thank you.
>  Could you commit the attached patch ?
>
> It adds some debug macros and correct nvram_init() call for other PPC
> architectures.

Thanks, applied as r264.