Re: [OpenBIOS] [PATCH 3/10] Don't stop at APPLE_VOID partition

[Mark Cave-Ayland]

On 09/08/11 22:54, William Hahne wrote:
> The void partitions can be occasionally found on Mac OS discs (10.2 for
> example.) Previously mac-parts would just stop at the first void
> partition meaning it would never try to boot from the HFS partition.
> Index: packages/mac-parts.c
>
> --- packages/mac-parts.c (revision 1041)
> +++ packages/mac-parts.c (working copy)
> @@ -165,9 +165,12 @@
> for (parnum = 1; parnum <= __be32_to_cpu(par.pmMapBlkCnt); parnum++) {
> SEEK( bs * parnum );
> READ( &par, sizeof(par) );
> if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE ||
>                        !__be32_to_cpu(par.pmPartBlkCnt) )
> if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE) {
>
> break;
> }
> if ( !__be32_to_cpu(par.pmPartBlkCnt) ) {
> continue; /* Just a void partition, ignore it. */
> }
>
> DPRINTF("found partition type: %s with status %x\n", par.pmPartType,
> __be32_to_cpu(par.pmPartStatus));

Same as my comment for patch 2/10.

ATB,

Mark.

[PATCH 3/10] Don't stop at APPLE_VOID partition

[William Hahne]

On Wed, Aug 10, 2011 at 5:50 AM, Mark Cave-Ayland <
[e-mail]> wrote:
> On 09/08/11 22:54, William Hahne wrote:
>
> The void partitions can be occasionally found on Mac OS discs (10.2 for
> > example.) Previously mac-parts would just stop at the first void
> > partition meaning it would never try to boot from the HFS partition.
> >
> > Index: packages/mac-parts.c
> > ==============================**==============================**=======
> > --- packages/mac-parts.c (revision 1041)
> > +++ packages/mac-parts.c (working copy)
> > @@ -165,9 +165,12 @@
> > for (parnum = 1; parnum <= __be32_to_cpu(par.pmMapBlkCnt)**; parnum++) {
> > SEEK( bs * parnum );
> > READ( &par, sizeof(par) );
> > if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE ||
> >                        !__be32_to_cpu(par.**pmPartBlkCnt) )
> > if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE) {
> >
> > break;
> > }
> > if ( !__be32_to_cpu(par.**pmPartBlkCnt) ) {
> > continue; /* Just a void partition, ignore it. */
> > }
> >
> > DPRINTF("found partition type: %s with status %x\n", par.pmPartType,
> > __be32_to_cpu(par.**pmPartStatus));
>
> Same as my comment for patch 2/10.

This was also found through testing although I would assume it is
documented. If you have a 10.2 disc (or I would assume most other early Mac
OS X discs) lying around you can look at the partition table and see the
void partitions.

William Hahne
> ATB,
>
> Mark.
>
> Sirius Labs: http://www.siriusit.co.uk/labs