j
: Next unread message k
: Previous unread message j a
: Jump to all threads
j l
: Jump to MailingList overview
Wrong encoding of "#address-cells" property can lead to a failure fetching correct value in my-#acells method. According to docs properties must be encoded with "encode-int". I spent some time looking at the docs and it is clear that encode-int produces quad-sized result (of size /l bytes).
This patch fixes pci helpers to encode to 32bit instead of 64bit values, and correctes my-address and my-unit methods to read 32bit data to match encode-int rules modules/bindings.c: also fixed set_int_property and get_int_property to match encode-int rules
Signed-off-by: Igor Kovalenko igor.v.kovalenko@gmail.com
Attachments:
On 5/19/09, Igor Kovalenko igor.v.kovalenko@gmail.com wrote:
Wrong encoding of "#address-cells" property can lead to a failure fetching correct value in my-#acells method. According to docs properties must be encoded with "encode-int". I spent some time looking at the docs and it is clear that encode-int produces quad-sized result (of size /l bytes).
This patch fixes pci helpers to encode to 32bit instead of 64bit values, and correctes my-address and my-unit methods to read 32bit data to match encode-int rules modules/bindings.c: also fixed set_int_property and get_int_property to match encode-int rules
Signed-off-by: Igor Kovalenko igor.v.kovalenko@gmail.com
With the patch, Sparc64 device tree is much better. This does not break my PPC tests, so if anybody sees problems with the patch, please comment pretty soon.
On 5/19/09, Igor Kovalenko igor.v.kovalenko@gmail.com wrote:
Wrong encoding of "#address-cells" property can lead to a failure fetching correct value in my-#acells method. According to docs properties must be encoded with "encode-int". I spent some time looking at the docs and it is clear that encode-int produces quad-sized result (of size /l bytes).
This patch fixes pci helpers to encode to 32bit instead of 64bit values, and correctes my-address and my-unit methods to read 32bit data to match encode-int rules modules/bindings.c: also fixed set_int_property and get_int_property to match encode-int rules
Signed-off-by: Igor Kovalenko igor.v.kovalenko@gmail.com
Thanks, applied (r493).