Hello. I'm on the driver floppy.c

[Анатолий Литвяков]

sorry for my english, I'm from Russia.
I think that you have, and Linux. there is a bug in the team
drive_specific_command
(0x8e). you pass the first parameter as (FD_Drive & 3). but you have to ((
FD_Drive & 3) <5). if I'm wrong then please explain how this team.

please reply to this message.
thanks in advance.

[Blue Swirl]

2010/12/21 Анатолий Литвяков :
> sorry for my english, I'm from Russia.
> I think that you have, and Linux. there is a bug in the team
> drive_specific_command (0x8e). you pass the first parameter as (FD_Drive &
> 3). but you have to ((FD_Drive & 3) <5). if I'm wrong then please explain
> how this team.

It looks like FD_DRIVESPEC command is only supported by 82078. I
didn't find a data sheet for that, can you point to one?

QEMU seems to ignore the drive bits in the first parameter.

[Blue Swirl]

On Thu, Dec 30, 2010 at 7:58 PM, Blue Swirl  wrote:
> 2010/12/21 Анатолий Литвяков :
> > sorry for my english, I'm from Russia.
> > I think that you have, and Linux. there is a bug in the team
> > drive_specific_command (0x8e). you pass the first parameter as (FD_Drive &
> > 3). but you have to ((FD_Drive & 3) <5). if I'm wrong then please explain
> > how this team.
>
> It looks like FD_DRIVESPEC command is only supported by 82078. I
> didn't find a data sheet for that, can you point to one?

OK, didn't use the right data sheet site:
http://www.datasheetarchive.com/pdf-datasheets/Datasheets-308/27656.html

So the drive bits should be ((FD_Drive & 3) << 5). Could you make a
patch with this change?

[Andreas Färber]

Am 21.12.2010 um 19:19 schrieb Анатолий Литвяков:
> I think that you have, and Linux. there is a bug in the team  
> drive_specific_command (0x8e). you pass the first parameter as  
> (FD_Drive & 3). but you have to ((FD_Drive & 3) <5). if I'm wrong  
> then please explain how this team.

drivers/floppy.c has one search hit for FD_DRIVE & 3. FD_DRIVE is  
#define'd as 0. So (FD_DRIVE & 3) is < 5.
Maybe I misunderstand the question? What problem exactly are you  
observing? If it's just about cosmetics, please supply a patch, that's  
international. :)

Спасибо,

Andreas