[PATCH] Keyboard property

[Olivier Danet]

The keyboard property should be empty.

NetBSD accesses the keyboard property in 'kernel/arch/sparc/dev/zs.c' and
checks this :
     (prom_getproplen(zsc->zsc_node, "keyboard") == 0)

...which is true only when the property exists but has no value. It
matches Sun's OpenBOOT behavior.

Signed-off-by: Olivier Danet 
===================================================================
--- drivers/escc.c    (révision 1257)
+++ drivers/escc.c    (copie de travail)
@@ -329,13 +329,13 @@
      fword("property");

if (keyboard) {
-        PUSH(-1);
-        fword("encode-int");
+        PUSH(0);
+        PUSH(0);
          push_str("keyboard");
          fword("property");

-        PUSH(-1);
-        fword("encode-int");
+        PUSH(0);
+        PUSH(0);
          push_str("mouse");
          fword("property");
      }
===================================================================

[Mark Cave-Ayland]

On 01/02/14 20:52, Olivier Danet wrote:
> The keyboard property should be empty.
>
> NetBSD accesses the keyboard property in 'kernel/arch/sparc/dev/zs.c' and
> checks this :
> (prom_getproplen(zsc->zsc_node, "keyboard") == 0)
>
> ...which is true only when the property exists but has no value. It
> matches Sun's OpenBOOT behavior.
> Signed-off-by: Olivier Danet
>
> --- drivers/escc.c (révision 1257)
> +++ drivers/escc.c (copie de travail)
> @@ -329,13 +329,13 @@
> fword("property");
>
> if (keyboard) {
> PUSH(-1);
> fword("encode-int");
> PUSH(0);
> PUSH(0);
>
> push_str("keyboard");
> fword("property");
> PUSH(-1);
> fword("encode-int");
> PUSH(0);
> PUSH(0);
>
> push_str("mouse");
> fword("property");
> }
> ===================================================================

Reviewed-by: Mark Cave-Ayland

ATB,

Mark.