j
: Next unread message k
: Previous unread message j a
: Jump to all threads
j l
: Jump to MailingList overview
On Sep 15, 2010, at 6:00 AM, openbios-request@openbios.org wrote:
Message: 1 Date: Wed, 15 Sep 2010 09:50:07 +0100 From: Mark Cave-Ayland mark.cave-ayland@siriusit.co.uk To: The OpenBIOS Mailinglist openbios@openbios.org Subject: Re: [OpenBIOS] corrections to vocabulary.fs Message-ID: 4C9088BF.4060803@siriusit.co.uk Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Programmingkid wrote:
I found a few documentation mistakes in the vocabulary.fs file. In the comment section of get-order and set-order, their comments are incorrect. For get-order the comment should be ( -- widn .. wid1 n). For set-order the comment should be ( widn .. wid1 n -- ). This page is where I found the correct comments: http://lars.nocrew.org/dpans/dpans16.htm#16.6.1.2197
Nice work. Can you provide a patch for us to review and commit?
ATB,
Mark.
--
I'm not very good with making patches, but I think this might work:
--- ./vocabulary.fs 2009-11-15 21:03:50.000000000 -0500 +++ /vocabulary.fs 2010-09-15 18:09:40.000000000 -0400 @@ -39,14 +39,14 @@ here 0 , ;
-: get-order ( -- wid1 .. widn n ) +: get-order ( -- widn .. wid1 n ) #order @ 0 ?do #order @ i - 1- cells context + @ loop #order @ ;
-: set-order ( wid1 .. widn n -- ) +: set-order ( widn .. wid1 n -- ) dup -1 = if drop forth-last 1 \ push system default word list and number of lists then
Attachments: