Re: [OpenBIOS] /packages/disk-label, /packages/sun-parts and /packages/misc-files

[Laurent Vivier]

> Mark Cave-Ayland wrote:
> > Hi folks,
> >
> > Is there some kind of specification for the above packages or are we 
> > free to design the interface as we choose? The reason I ask is that the 
> > current interposition order doesn't seem to be particularly logical. At 
> > the moment, the order goes like this for a CDROM:
> >
> > cdrom -> deblocker -> disk-label -> (misc-files or sun-parts or pc-parts)
> >
> > But I think it makes more sense to do this:
> >
> > cdrom -> deblocker -> disk-label -> (sun-parts or pc-parts) -> misc-files

Moreover, I think ext2, hfs, hfsplus, iso9660 can be moved to their own packages (as it is done on macintosh new world openfirmware). I have a patch on my disk doing this for ISO9660 (not sure) but it is 7 months old and I don't know if it applies (and works) anymore.

Regards,
Laurent

/packages/disk-label, /packages/sun-parts and /packages/misc-files

[Mark Cave-Ayland]

Laurent Vivier wrote:
> Moreover, I think ext2, hfs, hfsplus, iso9660 can be moved to their own packages (as it is done on macintosh new world openfirmware). I have a patch on my disk doing this for ISO9660 (not sure) but it is 7 months old and I don't know if it applies (and works) anymore.

Yeah, that would make sense - I just wasn't sure how far I could go to 
stay in line with the spec. If you'd like to post what you have so far, 
I'd be happy to take a look while I'm hacking around that area.

ATB,

Mark.

/packages/disk-label, /packages/sun-parts and /packages/misc-files

[Laurent Vivier]

Le vendredi 28 mai 2010 à 16:03 +0100, Mark Cave-Ayland a écrit :
> Laurent Vivier wrote:
> > Moreover, I think ext2, hfs, hfsplus, iso9660 can be moved to their own packages (as it is done on macintosh new world openfirmware). I have a patch on my disk doing this for ISO9660 (not sure) but it is 7 months old and I don't know if it applies (and works) anymore.
>
> Yeah, that would make sense - I just wasn't sure how far I could go to 
> stay in line with the spec. If you'd like to post what you have so far, 
> I'd be happy to take a look while I'm hacking around that area.

You can find attached my patch as it was on 2009-11-26, I just update it
to apply to current HEAD.

I don't know if it works or even if it can be compiled as is.

NOTE:
you need

<option name="CONFIG_ISO9660" type="boolean" value="true"/>

in your config.xml, which is enabled only for PPC for the moment.

Regards,
Laurent

/packages/disk-label, /packages/sun-parts and /packages/misc-files

[Laurent Vivier]

This one compiles and works (on ppc). I have tested with some ISOs
(Yaboot based, *BSD, haiku, morphos) and some disk images (Quik based
debians).

Please, test it with your disks. Don't forget:

<option name="CONFIG_ISO9660" type="boolean" value="true"/>
<option name="CONFIG_FSYS_ISO9660" type="boolean" value="false"/>

Regards,
Laurent

Le vendredi 28 mai 2010 à 21:15 +0200, Laurent Vivier a écrit :
> Le vendredi 28 mai 2010 à 16:03 +0100, Mark Cave-Ayland a écrit :
> > Laurent Vivier wrote:
> > > Moreover, I think ext2, hfs, hfsplus, iso9660 can be moved to their own packages (as it is done on macintosh new world openfirmware). I have a patch on my disk doing this for ISO9660 (not sure) but it is 7 months old and I don't know if it applies (and works) anymore.
> >
> > Yeah, that would make sense - I just wasn't sure how far I could go to 
> > stay in line with the spec. If you'd like to post what you have so far, 
> > I'd be happy to take a look while I'm hacking around that area.
>
> You can find attached my patch as it was on 2009-11-26, I just update it
> to apply to current HEAD.
>
> I don't know if it works or even if it can be compiled as is.
>
> NOTE:
> you need
>
>  <option name="CONFIG_ISO9660" type="boolean" value="true"/>
>
> in your config.xml, which is enabled only for PPC for the moment.
>
> Regards,
> Laurent

/packages/disk-label, /packages/sun-parts and /packages/misc-files

[Mark Cave-Ayland]

Laurent Vivier wrote:
> This one compiles and works (on ppc). I have tested with some ISOs
> (Yaboot based, *BSD, haiku, morphos) and some disk images (Quik based
> debians).
>
> Please, test it with your disks. Don't forget:
>
> <option name="CONFIG_ISO9660" type="boolean" value="true"/>
> <option name="CONFIG_FSYS_ISO9660" type="boolean" value="false"/>
>
> Regards,
> Laurent

Thanks for this Laurent.

Since most of my testing is currently on SPARC64, I had to fiddle a 
little bit with these options enabled as CONFIG_ISO9660 clashes with the 
default CONFIG_GRUBFS and CONFIG_FSYS_ISO9660 options.

Once I managed to build it, I had more of a play and found the in-built 
ISO9660 module to be sadly lacking. In particular, it is case-sensitive 
with respect to filenames, doesn't handle trailing periods correctly and 
has no knowledge of RockRidge extensions compared to the grubfs version 
which I fixed in r777.

Given that the grubfs code also supports a wider variety of filesystems, 
I'm quite tempted to rip out ALL the standard OpenBIOS fs drivers and 
make use of the grubfs ones instead. Would anyone have any major 
objections to this?

ATB,

Mark.