Re: [OpenBIOS] [PATCH 16/16] Fix the FMT_cell and FMT_ucell definitions for SPARC32.

[Andreas Färber]

Am 30.12.2010 um 19:07 schrieb Mark Cave-Ayland:
> This is required to enable a build with CONFIG_DEBUG_OFMEM set to  
> true to complete successfully.
> Signed-off-by: Mark Cave-Ayland
>
> openbios-devel/include/arch/sparc32/types.h |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/openbios-devel/include/arch/sparc32/types.h b/openbios- 
> devel/include/arch/sparc32/types.h
> index 444d648..e4f0f0d 100644
> --- a/openbios-devel/include/arch/sparc32/types.h
> +++ b/openbios-devel/include/arch/sparc32/types.h
> @@ -46,8 +46,8 @@ typedef uint32_t	ucell;
> typedef long long       dcell;
> typedef unsigned long long ducell;
>
> -#define FMT_cell    "%ld"
> -#define FMT_ucell   "%lu"
> +#define FMT_cell    "%d"
> +#define FMT_ucell   "%u"

Please use PRI{d,x}32. This may or may not require a pending patch of  
mine from the prom_args_t series.
> #define FMT_ucellx  "%08x"
> #define FMT_ucellX  "%08X"

[PATCH 16/16] Fix the FMT_cell and FMT_ucell definitions for SPARC32.

[Andreas Färber]

Am 30.12.2010 um 19:33 schrieb Andreas Färber:
> Am 30.12.2010 um 19:07 schrieb Mark Cave-Ayland:
> > This is required to enable a build with CONFIG_DEBUG_OFMEM set to  
> > true to complete successfully.
> > Signed-off-by: Mark Cave-Ayland
> >
> > openbios-devel/include/arch/sparc32/types.h |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/openbios-devel/include/arch/sparc32/types.h b/openbios- 
> > devel/include/arch/sparc32/types.h
> > index 444d648..e4f0f0d 100644
> > --- a/openbios-devel/include/arch/sparc32/types.h
> > +++ b/openbios-devel/include/arch/sparc32/types.h
> > @@ -46,8 +46,8 @@ typedef uint32_t	ucell;
> > typedef long long       dcell;
> > typedef unsigned long long ducell;
> >
> > -#define FMT_cell    "%ld"
> > -#define FMT_ucell   "%lu"
> > +#define FMT_cell    "%d"
> > +#define FMT_ucell   "%u"
>
> Please use PRI{d,x}32. This may or may not require a pending patch  
> of mine from the prom_args_t series.

PRI{d,u}32 of course.
> > #define FMT_ucellx  "%08x"
> > #define FMT_ucellX  "%08X"