broken qemu-system-sparc64 ide cdrom after r161 "Fix Sparc64 insw and outsw"

[Igor Kovalenko]

Seems like that r161 commit broke qemu-system-sparc64 ability to
access ide cdrom (that is what I test now), because it makes ide i/o
port word transfers byteswapped wrt what ide.c expects.
If I revert r161 then cdrom becomes visible.

I also need the following patch to unswap drive identification string
for printk display.

Now I have: "drive0 [ATAPI cdrom]: QEMU DVD-ROM"

Index: drivers/ide.c
===================================================================
--- drivers/ide.c       (revision 185)
+++ drivers/ide.c       (working copy)
@@ -861,10 +868,10 @@
        /*
         * if little endian arch, byte swap the string
         */
-#ifdef CONFIG_LITTLE_ENDIAN
+#ifdef CONFIG_BIG_ENDIAN
        for (p = end ; p != s;) {
                unsigned short *pp = (unsigned short *) (p -= 2);
-               *pp = __be16_to_cpu(*pp);
+               *pp = __le16_to_cpu(*pp);
        }
 #endif

-- 
Kind regards,
Igor V. Kovalenko

[Blue Swirl]

On 4/23/08, Igor Kovalenko <[e-mail]> wrote:
> Seems like that r161 commit broke qemu-system-sparc64 ability to
>  access ide cdrom (that is what I test now), because it makes ide i/o
>  port word transfers byteswapped wrt what ide.c expects.
>  If I revert r161 then cdrom becomes visible.
>
> I also need the following patch to unswap drive identification string
>  for printk display.
>
> Now I have: "drive0 [ATAPI cdrom]: QEMU DVD-ROM"

Thanks, applied.