Re: [OpenBIOS] [PATCH 5/10] Add draw-rectangle to the display package

[Mark Cave-Ayland]

On 10/08/11 16:35, William Hahne wrote:
> I am not sure if it is officially part of any specification. BootX
> doesn't even assume that it was there and attempted to add its own
> "draw-rectangle" word, but unfortunately the method it uses to add words
> to packages doesn't work with OpenBIOS. Just adding draw-rectangle
> seemed like a much simpler and safer solution than changing the way
> device packages work. Also from what I could see it looked like a
> serious rewrite might be necessary just to get one small edge case to work.

Ah I see - so the real bug is that OpenBIOS can't add the word 
correctly? Do you have any DEBUG_CIF traces so we can determine the 
Forth being sent to OpenBIOS and come up with a fix for that?

ATB,

Mark.

[PATCH 5/10] Add draw-rectangle to the display package

[William Hahne]

On Mon, Aug 15, 2011 at 6:57 AM, Mark Cave-Ayland
 wrote:
> Ah I see - so the real bug is that OpenBIOS can't add the word correctly? Do
> you have any DEBUG_CIF traces so we can determine the Forth being sent to
> OpenBIOS and come up with a fix for that?

I would recommend looking at the BootX source directly for this. If
you look at http://opensource.apple.com/source/BootX/BootX-45/bootx.tproj/sl.subproj/dis...
line 403. You can see that it just throws the phandle directly into
active-package. The device package implementation in OpenBIOS expects
active-package to only be set by calling the active-package! word. If
it is set directly then it doesn't actually change the active-package.

I would like to note that this particular patch is optional for
booting Mac OS X. It is just nice since it allows the Apple logo to be
displayed.
> ATB,
>
> Mark.
>
> Sirius Labs: http://www.siriusit.co.uk/labs