On Fri, 19 Jul 2019, Mark Cave-Ayland wrote:
On 16/07/2019 13:57, BALATON Zoltan wrote:
On Sun, 14 Jul 2019, Jd Lyons wrote:
I suppose the first thing we need it the my-space patch so we can get the correct value before map-in. Attachment: openbios-pci-set-args.patch
Why is this patch not in master yet?
Well sometimes I have been known to have a life outside of QEMU/OpenBIOS... but
Sure, although we only know about this side of your life here :-). I did not mean to complain about you being late with this just asked what's the reason this is a separate patch and not merged yet. It was forwarded to me by Jd and I though this was done when he was trying to run the NVidia ROM a few months ago so I thought it's an older patch that could have been merged unless there's some problem with it that kept it out of master.
really quickly there are 2 reasons: 1) it's a bit of a hack (the real solution is to build the DT in order rather than constantly switching around active package/current instance, otherwise your instance variables can be initialised incorrectly) and 2)
OK, is that something getting the device tree from QEMU as FDT then unflattening it to construct the OF device-tree would help with or is it only about the pci devices part of the tree? Still I think getting a complete tree from QEMU and only adding some properties as SLOF does is better then the current situation where OpenBIOS needs knowledge about every change in QEMU so I think the way to avoid this is to do what SLOF does. This is more work once but then helps to get rid of a lot of hacks and make it less work later because a lot of things can be done in QEMU alone not requiring an OpenBIOS update as well so would make OpenBIOS more stable.
As I mentioned in my previous email I am currently working on a patchset to implement
- properly for PCI devices which I hope to post to the list soon.
Is there more info available on this? If you don't have time to work on it please share the info with the list at least so someone else could have a chance to help (although I get the impression there's no one else who cares about OpenBIOS besides you here).
Regards, BALATON Zoltan