[OpenBIOS] Re: [PATCH] cuda: fix reset-all and power-off words

[Hervé Poussineau]

Le 19/09/2021 à 12:25, Mark Cave-Ayland a écrit :
> There is a long-standing bug in the CUDA implementation of the reset-all and
> power-off words whereby an extra byte is written after the CUDA_RESET_SYSTEM
> and CUDA_POWERDOWN commands.
>
> This extra byte used to be ignored in QEMU until commits 017da0b568 ("cuda:
> port POWERDOWN command to new framework") and 54e894442e ("cuda: port
> RESET_SYSTEM command to new framework") added a check which rejects the
> command if the command length is incorrect.
>
> Fix the outgoing command length to remove the extra byte which allows the
> reset-all and power-off words to work in QEMU once again.
>
> Signed-off-by: Mark Cave-Ayland 
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/624
>
> drivers/cuda.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Hervé Poussineau