On 21/06/13 19:10, Stefan Reinauer wrote:
Hi Stefan,
- Mark Cave-Aylandmark.cave-ayland@ilande.co.uk [130526 15:02]:
diff --git a/openbios-devel/forth/device/display.fs b/openbios-devel/forth/device/display.fs index bbd2b13..0df7165 100644 --- a/openbios-devel/forth/device/display.fs +++ b/openbios-devel/forth/device/display.fs @@ -44,6 +44,10 @@ hex 0 value foreground-color 0 value background-color
+\ internal values read from QEMU firmware interface +0 value qemu-video-addr +0 value qemu-video-height +0 value qemu-video-width
Not that it matters much, but maybe qemu related code could go into another file, not the generic display driver?
There is another patchset I posted to the list last week which cleans this up further - the values for bit depth, width and height are initially set to VGA_DEFAULT_DEPTH, VGA_DEFAULT_WIDTH and VGA_DEFAULT_HEIGHT. There is then a #ifdef CONFIG_QEMU... #endif section that updates these values from the QEMU FWCfg interface if doing a QEMU build.
Just to let you know where I'm going with this next: I have an alpha quality patch that adds a <object source="foo" type="fcode" /> tag for <library> in build.xml, and also a <fcode ..> tag that invokes toke on the source file. This enables me then to add a Fcode-generated file into a dictionary using $encode-file in the arch-specific dictionaries.
This gets us to a stage where I can convert drivers/tcx.fs and drivers/vga.fs over to Fcode, include them in the final dictionary, and have them invoked using byte-load during probe. If you would like to review this forthcoming patchset then that would be a great help :)
ATB,
Mark.