On 23/02/16 20:19, Programmingkid wrote:
Just this one patch, or the entire patchset? Pretty much everything just works with "git am" these days?
It was with this patch only. This patch would not show up when I went to view it as raw text.
How strange. The entire patchset was a straightforward invocation of git format-patch.
I think there are two issues here: firstly something does cause memory corruption which can cause random crashes under OS 9, and secondly the changes to the serial ports. We know that OT probe causes OS 9 to crash/hang when booting from a vanilla image, but the probe doesn't take place on pre-installed images. In these cases the hang is almost better than the crash in that at least the OS gets to the point where it can probe the serial ports, it is just that the QEMU emulation is lacking.
Agreed.
If the change in behaviour occurs when booting from a fresh ISO then I'm not too worried because everyone testing at the moment will have removed these extensions from their images. However if existing installed images start to fail then perhaps the patch needs more work.
It was fresh ISO's that I used for testing.
Well that's definitely not a regression, just not an improvement :) As long as yourself/Howard are happy that the pre-installed OS 9 images work then I think we're good.
ATB,
Mark.