Re: [OpenBIOS] [PATCH v3 1/2] ppc: Adjust isa_io_base for ppc64

[Blue Swirl]

On Sat, Nov 20, 2010 at 4:42 PM, Andreas Färber  wrote:
> Am 13.11.2010 um 10:25 schrieb Andreas Färber:
> > To avoid cast warnings, use a 64-bit ISA I/O base on ppc64.
> >
> > v3:
> > Adjust unix target, pointed out by Blue.
> >
> > Unify ppc and sparc64, using unsigned long instead of uintptr_t.
> >  It is initialized from pci_arch_t, which uses unsigned long.
> > Update other ppc targets, pointed out by Blue.
>
> Ping. Opinions on which type is more correct to use here? Should we go with
> uintptr_t and change PCI instead?

For Sparc64, isa_io_base should be 64 bits. Any one of unsigned long,
uintptr_t or phys_addr_t would be correct. Sparc32 does not use ISA,
so that leaves the decision to PPC/PPC64.