Thank you for this.
I think I'll make it more general, though, with some perl script to test what sizes are available etc., and generating a header file from that info.
Don't be alarmed by the "cruft" in paflof.c anyway; it's just the unix-specific userland version; it is _allowed_ to contain filthy debugging stuff ;)
Btw, paflof compiles cleanly both on 32 and 64 bit systems now. Oh, and the 128-bit type is only needed on 64-bit hosts if double cell arithmetic is needed, and then only if that arithmetic _actually_ uses "big" values (i.e., we don't really have a problem here now :) )
I'll look into this some more...
Segher
Stefan Reinauer wrote:
Hi,
ok, this time I redid the patch to make paflof sane on 64bit platforms in a cleaner way, using abstracted defines that are dependent on certain platform specifics. As this is platform dependent stuff which has basically nothing to do with paflof itself, I moved it to a new file: machdep.h. I moved the sanity check out of paflof.c into machdep.c, which we will probably not need to link in case we know an architecture/compiler combination is sane.
We really need to make sure we are 64bit clean from the beginning so we recognize early what problems we might have to face getting paflof portable.
Segher, is this ok to check in from your side? If so, please do!
Stefan
-- The x86 isn't all that complex - it just doesn't make a lot of sense. -- Mike Johnson, Leader of 80x86 Design at AMD Microprocessor Report (1994)
paflof-machdep2.diffName: paflof-machdep2.diff Type: Plain Text (text/plain)
- To unsubscribe: send mail to majordomo@freiburg.linux.de with 'unsubscribe openbios' in the body of the message http://www.freiburg.linux.de/OpenBIOS/ - free your system..