On Sun, 21 Jul 2019, Segher Boessenkool wrote:
On Sun, Jul 21, 2019 at 12:08:21PM +0100, Mark Cave-Ayland wrote:
I'm not sure what you mean about returning different values? At least with my patchset and this morning's patch applied they both looks the same here:
0 > " /pci/usb" open-dev to my-self ok 0 > my-unit ok 3 > u. 6800 ok 2 > u. 0 ok 1 > u. 0 ok 0 > my-address ok 2 > my-space ok 3 > u. 6800 ok 2 > u. 0 ok 1 > u. 0 ok
That looks good.
Segher's comment about my-unit is an implementation detail rather than a definition from the specification,
Which comment?
That my-unit should be the same as my-address my-space which without Mark's latest patch does not hold in OpenBIOS. But that patch does not change where these values are pulled from just calls set-args which apparently syncs the places space and address come from while my-unit gets space from somewhere else.
Regards, BALATON Zoltan