After these patches there's still an extra warning (besides the string.h bit):
In file included from /builddir/build/BUILD/openbios-1.1/drivers/obio.c:14:0: /builddir/build/BUILD/openbios-1.1/drivers/obio.c:30:23: warning: 'ob_obio_size_' defined but not used [-Wunused-const-variable] DECLARE_UNNAMED_NODE( ob_obio, INSTALL_OPEN, sizeof(int) ); ^ /builddir/build/BUILD/openbios-1.1/include/libopenbios/bindings.h:132:18: note: in definition of macro 'DECLARE_UNNAMED_NODE' static const int name##_size_ = size; ^~~~ /builddir/build/BUILD/openbios-1.1/drivers/obio.c:30:23: warning: 'ob_obio_flags_' defined but not used [-Wunused-const-variable] DECLARE_UNNAMED_NODE( ob_obio, INSTALL_OPEN, sizeof(int) ); ^ /builddir/build/BUILD/openbios-1.1/include/libopenbios/bindings.h:131:18: note: in definition of macro 'DECLARE_UNNAMED_NODE' static const int name##_flags_ = flags; \
- Cole
On 03/11/2016 11:25 AM, Mark Cave-Ayland wrote:
Make sure we use the correct REGISTER_NODE macro when registering the /memory and /virtual-memory nodes.
Signed-off-by: Mark Cave-Ayland mark.cave-ayland@ilande.co.uk
openbios-devel/arch/sparc64/lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/openbios-devel/arch/sparc64/lib.c b/openbios-devel/arch/sparc64/lib.c index e9101af..4709ca8 100644 --- a/openbios-devel/arch/sparc64/lib.c +++ b/openbios-devel/arch/sparc64/lib.c @@ -458,10 +458,10 @@ NODE_METHODS(mmu) = { void ob_mmu_init(const char *cpuname, uint64_t ram_size) { /* memory node */
- REGISTER_NODE_METHODS(memory, "/memory");
REGISTER_NODE(memory);
/* MMU node */
- REGISTER_NODE_METHODS(mmu, "/virtual-memory");
REGISTER_NODE(mmu);
ofmem_register(find_dev("/memory"), find_dev("/virtual-memory"));