On 11/02/2021 17:39, Segher Boessenkool wrote:
Hi!
On Thu, Feb 11, 2021 at 04:52:06PM +0000, Mark Cave-Ayland wrote:
On 11/02/2021 16:07, Segher Boessenkool wrote:
But that loses information, there is no hint *why* the device is ignored anymore. Maybe you can do a better name (one that actually means the same as blacklisted), or add a comment somewhere?
Any suggestion for better names?
ignore_broken_device perhaps... Something like that. Someone who knows exactly why the device is blacklisted can tell you.
FWIW the comments in the pci_xbox_blacklisted() already give the reasoning:
<snip>
Ah excellent :-) Then it probably is fine. (The chommit message should mention this though!)
Just "ignore_device" would fit the code perfectly well here, but then you need to add a comment (where it is used) saying why that is done. The existing name suggests it is because the device is broken or similar; that it cannot be handled like other devices anyway.
I prefer to keep the pci_xbox prefix
Yes of course, I'm just a lazy typist.
How about a single line comment above the call to pci_xbox_ignore_device() that says something like this?
/* Some in-built XBox PCI devices are unsupported/unavailable */Excellent :-)
Thanks guys,
Great! I can take Philippe's v3 and add the extra comment during merge. I'll give the outstanding patches a test and push them to git if everything seems good.
ATB,
Mark.