Re: [OpenBIOS] [PATCH 1/2] Fix NULL-dereferencing in sunparts_open

[Blue Swirl]

On Sat, Apr 6, 2013 at 6:05 PM, Mark Cave-Ayland
 wrote:
> On 06/04/13 18:42, Artyom Tarasenko wrote:
> > > Thanks - this is a similar bug to the one that was in mac-parts.c so I've
> > > applied it.
> >
> > I've found it after applying the patch preventing mapping of the page
> > 0 and looking what breaks.
> > It may be a good idea not to map the page 0 on other architectures too.
>
> Yeah I'd be quite tempted to make this the default (and it's probably why
> load-base is often set to 0x4000 so page 0 can be unmapped).
>
> Blue - what do you think?

IIRC I actually used a similar change earlier to find some bugs, but I
didn't make it permanent because some of the bugs were in Forth and we
had no debugger for it at that time. Probably now it's OK.
> ATB,
>
> Mark.