On Sat, 8 Mar 2014, Mark Cave-Ayland wrote:
This patch looks fine, so I've just applied this to the main repository (with credit to Oliver).
Thanks.
I would say do a separate patchset with patches 1 and 4 with CC to the PPC maintainers (Alex and Andreas) and make sure that they are happy with the changes.
OK, I will do so after I came up with a hopefully final version. I may need to change them still.
Patch 2 is little more tricky; I'd be tempted to move the "OpenBIOS" version to another property in the root node of the tree and set it to "device-tree" for compatibility reasons. Then again I'm finding it quite hard to justify
I don't mind which solution will be chosen as long as we can match the Apple behaviour on PPC. I see these alternatives:
1. My first version was to change it for all but this does not seem to be the right choice.
2. Mark's suggestion was to move the current value to some other property and change the name. If we choose this we need to decide the name of the new property. My suggestion for this was "vendor" but this is just a guess based on nothing and I'm open to other suggestions. If we agree on a name I can prepare a patch. Does the name of the root node actually matters to anyone on platforms other than Apple?
3. I may look into enclosing it in [IFDEF] CONFIG_PPC or even patching it up in qemu/init.c based on what is_apple returns but does it worth the hassle?
Regards, BALATON Zoltan