On 26/06/2019 21:59, BALATON Zoltan wrote:
On Wed, 26 Jun 2019, Mark Cave-Ayland wrote:
On 14/06/2019 21:42, BALATON Zoltan wrote:
But that's just my view and I don't really mind either way, so don't take this as saying not to apply your patches.
Thanks for the feedback. Having reflected on this over the past week, I'm still happy with the approach taken (since it's consistent with what I've been doing for a while now) and given that it's coming up to QEMU freeze I'd like to have the fix included in the next release. So this is now pushed to master.
Apropos freeze, is there a chance to include my patch as well:
https://mail.coreboot.org/hyperkitty/list/openbios@openbios.org/thread/JXPLQ...
which is needed to run MorphOS on mac99 and have working USB? I have a patched OpenBIOS binary on my QEMU Amiga page which I haven't updated for a while so it may stop working at some point with newer QEMU releases. So having this in official OpenBIOS that comes with QEMU would simplify things for users. Unless there's something that breaks with it it's not worse than the other work arounds already in OpenBIOS IMO.
From what I can see there is no follow-up patch to deal with fixing up bus-range for subsequent PCI buses? Whilst I agree with you that OpenBIOS does have a fair number of workarounds, I don't want to introduce something that deliberately breaks the conformance of the DT to the specifications when the existing code makes considerable efforts to do the right thing.
ATB,
Mark.