Re: [OpenBIOS] PPC: QEMU breaks static variables in OpenBIOS

[Blue Swirl]

On Sat, Jan 5, 2013 at 8:01 PM, Mark Cave-Ayland
 wrote:
> On 05/01/13 19:43, Mark Cave-Ayland wrote:
> > If you could review, and perhaps even enhance with the relevant change
> > for PPC64 then that would be great!
>
> Actually here's a revised version that moves the __next_grab_slot back into
> C which is simpler still and continues to work for me. I guess in this form
> the same change could be applied as-is to hash_page_64()?

The address arithmetic looks very similar to va2pa() or ea_to_phys().
Could one of those be used instead?

Also since this is pretty hot code path, could you initialize the
pointer and perform the calculations just once during init?
> ATB,
>
> Mark.