Re: [OpenBIOS] [Qemu-devel] Fix double nvram entry on newworld

[Alexander Graf]

Am 03.02.2013 um 15:18 schrieb Anthony Liguori :
> Alexander Graf  writes:
> > Am 02.02.2013 um 14:05 schrieb Blue Swirl :
> > > On Thu, Jan 31, 2013 at 3:10 PM, Alexander Graf  wrote:
> > > > On 30.01.2013, at 11:29, Amadeusz Sławiński wrote:
> > > > > Fix double nvram entry on newworld
> > > > >
> > > > > There are two nvram entries on newworld (for example qemu -M mac99)
> > > > >
> > > > > The first one (nvram@fff04000) has initialized .properties while the
> > > > > other one has words.
> > > > >
> > > > > 0 > dev / ls
> > > > > ...
> > > > > fff75e24 pci@f2000000
> > > > > fff77848 nvram@fff04000
> > > > > fff778e0 nvram
> > > > > ok
> > > > > 0 > dev /nvram@fff04000  ok
> > > > > 0 > words
> > > > > ok
> > > > > 0 > .properties
> > > > > name                      "nvram"
> > > > > #bytes                    2000
> > > > > reg                       fff04000   00004000
> > > > > device_type               "nvram"
> > > > > compatible                "nvram,flash"
> > > > > ok
> > > > > 0 > dev /nvram@0  ok
> > > > > 0 > words close open seek write read size
> > > > > ok
> > > > > 0 > .properties
> > > > > name                      "nvram"
> > > > > ok
> > > > >
> > > > > This patch fixes initialization, so only one node is created
> > > > > containing both .properties and words.
> > > > >
> > > > > 0 > dev / ls
> > > > > ...
> > > > > fff75e24 pci@f2000000
> > > > > fff77868 nvram@fff04000
> > > > > ok
> > > > > 0 > dev /nvram@fff04000  ok
> > > > > 0 > words close open seek write read size
> > > > > ok
> > > > > 0 > .properties
> > > > > name                      "nvram"
> > > > > #bytes                    2000
> > > > > reg                       fff04000   00004000
> > > > > device_type               "nvram"
> > > > > compatible                "nvram,flash"
> > > > > ok
> > > > >
> > > > > Signed-off-by: Amadeusz Sławiński
> > > >
> > > > Blue, once this patch is in the tree, do you think you could rebuild OpenBIOS for QEMU, so that it will land in 1.4?
> > >
> > > Sorry, it didn't happen before the freeze. I'm not sure if new
> > > OpenBIOS images qualifies as a bug fix.
> >
> > I would say yes ;).
> >
> > Anthony, any objections from your side?
>
> Nope.

Awesome!

Blue, mind to push new binaries? I'm currently at FOSDEM - not the greatest place to do this at ;).

Alex