On 20/01/18 14:38, Jd Lyons via OpenBIOS wrote:
This patch should get all 7447a cpus working with openbios, needs a corresponding patch to Qemu-ppc for the v1.5
diff --git a/arch/ppc/qemu/init.c b/arch/ppc/qemu/init.c index 5ce080c..09b2db4 100644 --- a/arch/ppc/qemu/init.c +++ b/arch/ppc/qemu/init.c @@ -550,6 +550,18 @@ static const struct cpudef ppc_defs[] = { .tlb_size = 0x80, .initfn = cpu_g4_init, },
- .iu_version = 0x80030000,
- .name = "PowerPC,G4",
- .icache_size = 0x8000,
- .dcache_size = 0x8000,
- .icache_sets = 0x80,
- .dcache_sets = 0x80,
- .icache_block_size = 0x20,
- .dcache_block_size = 0x20,
- .tlb_sets = 0x40,
- .tlb_size = 0x80,
- .initfn = cpu_g4_init,
+}, { .iu_version = 0x00390000, .name = "PowerPC,970",
The basic patch looks fine, although a subject prefix with "ppc: " should be used. I can also see some whitespace errors, although I'm not sure if these are introduced by your email client or not?
If you are unsure about suitable commit messages then do have a look at the existing history (also available online at https://git.qemu.org/?p=openbios.git;a=summary) for inspiration.
ATB,
Mark.