On Thu, Feb 11, 2021 at 04:34:38PM +0100, Philippe Mathieu-Daudé wrote:
Hi Segher,
On 2/11/21 3:55 PM, Segher Boessenkool wrote:
On Thu, Feb 11, 2021 at 03:42:44PM +0100, Philippe Mathieu-Daudé wrote:
In order to use inclusive terminology, rename pci_xbox_blacklisted() as pci_xbox_ignore_device(), and remove an obvious comment.
But that loses information, there is no hint *why* the device is ignored anymore. Maybe you can do a better name (one that actually means the same as blacklisted), or add a comment somewhere?
Any suggestion for better names?
ignore_broken_device perhaps... Something like that. Someone who knows exactly why the device is blacklisted can tell you.
Just "ignore_device" would fit the code perfectly well here, but then you need to add a comment (where it is used) saying why that is done. The existing name suggests it is because the device is broken or similar; that it cannot be handled like other devices anyway.
You cannot just replace terminology with other words that do not have the same connotations without losing important information, so any such replacement should be done by people who understand the code well :-(
Segher