On Fri, 28 Jun 2019, Mark Cave-Ayland wrote:
On 26/06/2019 21:59, BALATON Zoltan wrote:
https://mail.coreboot.org/hyperkitty/list/openbios@openbios.org/thread/JXPLQ...
which is needed to run MorphOS on mac99 and have working USB? I have a patched OpenBIOS binary on my QEMU Amiga page which I haven't updated for a while so it may stop working at some point with newer QEMU releases. So having this in official OpenBIOS that comes with QEMU would simplify things for users. Unless there's something that breaks with it it's not worse than the other work arounds already in OpenBIOS IMO.
From what I can see there is no follow-up patch to deal with fixing up bus-range for subsequent PCI buses? Whilst I agree with you that OpenBIOS does have a fair number of workarounds, I don't want to introduce something that deliberately breaks the conformance of the DT to the specifications when the existing code makes considerable efforts to do the right thing.
I've sent a v5 to the list which also patches bus-range of second pci bus to match a PowerMac3,1 device tree. It works with MorphOS both ways as long as /pci@f0000000 is present and is before /pci@f2000000 (I don't think MorphOS considers bus-range property just reads these sequentially). I think adding this missing pci bus also fixes the bus-master bit for the network cards that needed a hack in OpenBIOS to work so those work arounds could be reverted now too but I haven't tested that.
Regards, BALATON Zoltan