On Sun, 21 Jul 2019, Mark Cave-Ayland wrote:
Why isn't my-unit is just my-address my-space and how can these return different values? Should these values be stored on the same place and all of these words get it from that one place? Apparently not there are several places these are stored and the problem is that they get out of sync isnt'it?
I'm not sure what you mean about returning different values? At least with my patchset and this morning's patch applied they both looks the same here:
I meant before the patch they could refurn different values which means that space address (the one my-space gets it from) can become unsynced from the unit address (the one that my-unit looks at) and this probably should not happen so it suggests there might be a problem here which could be prevented by ensuring space address is only stored at one place and both my-unit and my-space get it from that same place which currently does not seem to be the case.
Segher's comment about my-unit is an implementation detail rather than a definition from the specification, so I wouldn't worry about this. Given that the above looks
I don't care much as long as it works but maybe it would help if I understood the implementation detail why my-space and my-unit are not equivalent in OpenBIOS (for FDT unflattening maybe I'll need to get more understanding of this).
correct I'd say it's time to move on to the PCI mapping as per the outline given in my previous email.
Yes, more on that in next message.
Regards, BALATON Zoltan