On 22/04/15 11:48, Andreas Färber wrote:
Am 20.04.2015 um 15:40 schrieb Programmingkid:
This patch gives the fcode-utils' toke, detok, and romheaders commands an install target. This makes "make install" work.
Changes since v1:
- Added DESTDIR variable
Signed-off-by: John Arbuckle <programmingkidx@gmail.com mailto:programmingkidx@gmail.com>
Index: detok/Makefile
--- detok/Makefile(revision 1334) +++ detok/Makefile(working copy) @@ -23,7 +23,7 @@ #
PROGRAM = detok
+DESTDIR=/usr/local/bin
Sorry, I see that my message was inconsistent. I really meant DESTDIR=/usr/local with DESTDIR=/usr as test case ...
CC ?= gcc STRIP= strip INCLUDES = -I../shared @@ -63,3 +63,5 @@ .c.o: $(CC) -c $(CFLAGS) $(INCLUDES) $< -o $@
+install: +cp $(PROGRAM) $(DESTDIR)/$(PROGRAM)
... which here means:
mkdir -p $(DESTDIR)/bin cp $(PROGRAM) $(DESTDIR)/bin/$(PROGRAM)
And the same below.
Apart from HTML looking good otherwise.
Yes, I agree too. I'll post my tidied-up version of the patch to the list and commit it later if no-one has any objections. BTW Andreas did you want to give an explicit R-B for the patch? Let me know if you would like it added before commit.
ATB,
Mark.