On Sun, Feb 14, 2016 at 11:08:10AM +0000, Mark Cave-Ayland wrote:
On 13/02/16 22:47, Segher Boessenkool wrote:
On Sat, Feb 13, 2016 at 04:10:57PM +0000, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland mark.cave-ayland@ilande.co.uk
Signed-off-by: Segher Boessenkool segher@kernel.crashing.org
Have you tested this? I just typed it in :-)
Indeed, and it actually works!
+: rot13-str ( str len -- newstr len )
- \ Encode copy of input string
- strdup 2dup $rot13
+;
I would do without this one btw, just put the strdup in the caller.
Yeah I'm happy to fold $rot13/rot13-str together but thought there may be another reason for doing it as you suggested. I'll update this for the next revision and add your S-o-B above.
I only did rot13-str with those semantics because you had it before as well :-) With $rot13 (or call it differently, whatever name fits existing practice best) rot13-str is just stringing together two unrelated things (well, three: allocation, strdup, rot13), and it's not an oft-used phrase, so things are easier to read if you just keep it separate. Very minor, of course.
Segher