On Sat, 8 Mar 2014, Mark Cave-Ayland wrote:
The patches look good, and I don't see any regressions against my -M mac99 PPC images here so I've committed all but patch 4 of this series.
The reason I haven't applied patch 4 is because this is going to need review from someone on the PPC side (Alex/Andreas), although the basic concept seems fine. Thanks a lot for the patches!
Thanks. I now have these patches in my tree that are not yet merged:
1. patch 4 you mentioned above
2. Change the device device name in openbios-devel/forth/device/tree.fs to device-tree Not sure what was the consensus of the review for this one.
3. In openbios-devel/libopenbios/client.c fix debug output: } else if (strcmp(service, "nextprop") == 0) { printk(FMT_prom_arg "\n", pb->args[pb->nargs]); - memdump(arg2pointer(pb->args[2]), pb->args[pb->nargs]); + memdump(arg2pointer(pb->args[2]), 32); } else if (strcmp(service, "setprop") == 0) { printk(FMT_prom_arg "\n", pb->args[pb->nargs]); Provided by Olivier Danet here: http://www.openfirmware.info/pipermail/openbios/2014-March/008146.html
4. A new one that adds tlb-sets, tlb-size and bus-frequency properties in openbios-devel/arch/ppc/qemu/init.c but only for G4 and I'm not sure if they are really needed but these fill in some values in MorphOS debug log.
What to do with these?
Regards, BALATON Zoltan