On 13/07/11 16:24, Bob Breuer wrote:
I've found the cause - my-self was still 0 when calling new-device, so the $call-parent in set-args was failing. OpenBIOS treats select-dev and open-dev as the same, but they are not, see the of1275 errata for section H.8. Most importantly, open-dev does not set my-self, while select-dev does.
OBP uses select-dev to make begin-package almost trivial, as in : begin-package ( ... ) select-dev new-device set-args ;
Any objection to simplifying the OpenBIOS version of begin-package to match the OBP version, and moving the extra logic from begin-package into select-dev?
That sounds sensible, so none from this end. If you post a patch, I'll test it on my various CD images and make sure it doesn't cause any Fcode regressions there.
ATB,
Mark.