On 02/10/2021 20:00, Mark Cave-Ayland wrote:
IIRC the last time you posted the patch my comment was that I would be happy to take the patch as-is, as long as the extra PCI bus is added to the QEMU mac99 machine beforehand. Device trees shouldn't be advertising devices that don't exist within the machine, since the existence of a device node will indicate that guest OSs should try to probe for it and the behaviour when the device doesn't exist is undefined.
And also while I remember: this is assuming that the bus numbers are correct according to a reference device tree (I can't remember the exact outcome of the discussion as to whether each bus number is unique beneath the host bridge or throughout the entire device tree).
ATB,
Mark.