On 07/08/16 17:17, BALATON Zoltan wrote:
On Sun, 7 Aug 2016, Mark Cave-Ayland wrote:
Some old bootloaders specifically look for the keyboard device via the kbd alias, so add this to keep them happy.
Signed-off-by: Mark Cave-Ayland mark.cave-ayland@ilande.co.uk
arch/ppc/qemu/qemu.fs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/ppc/qemu/qemu.fs b/arch/ppc/qemu/qemu.fs index 3d99a34..d683421 100644 --- a/arch/ppc/qemu/qemu.fs +++ b/arch/ppc/qemu/qemu.fs @@ -73,7 +73,8 @@ variable keyboard-phandle 0 keyboard-phandle ! keyboard-phandle @ if active-package " /aliases" find-device
- keyboard-phandle @ get-package-path
- keyboard-phandle @ get-package-path 2dup
- encode-string " kbd" property encode-string " keyboard" property active-package! then
I think this is wrong for mac99. I could not find any device tree dumps where this was present on real hardware. Maybe it was present on old world Macs (could not verify that as I've found no dumps from a beige G3 Mac, if anyone has access to one could they check devalias in OpenFirmware?).
It's definitely present for older Macs (and yes, I can confirm it appears on the device tree I have for a G3 beige).
Maybe you need this on mac99 because you are trying to boot stuff on it that was not supposed to run on this machine or because we emulate an ADB keyboard instead of the USB one found on real hardware. Does removing the ADB and using a USB keyboard and mouse improve things on mac99?
I guess I could add logic to make it so this alias only appears on -M g3beige, but then that seems more effort than it is worth than just leaving it there unconditionally.
ATB,
Mark.