9 Apr
2013
9 Apr
'13
11:12 p.m.
On 09/04/13 21:00, Artyom Tarasenko wrote:
You seem not to like my
#define LOWMEM_START PAGE_SIZE
? I think it would have made distinguishing between the page size and the offset parameters more obvious.
When I took a look at your patch, I felt that with a comment and PAGE_SIZE on its own that it was fairly obvious what was happening (as I can't see it being something that people would want to keep changing). I don't feel overwhelmingly strongly about it, so if you or anyone else feel there is a good case for doing it that way then I'm happy to be persuaded.
I think the most important thing at the moment is to work out why SPARC64 dereferences a NULL pointer during PCI enumeration though :/
ATB,
Mark.