On 30/12/10 19:25, Andreas Färber wrote:
Only because I was in two minds with regards to whether to keep pa2va and va2pa as "symmetrical" as possible. I'm happy to go with whatever you think is best.
Well I did point out that we're missing the opposite direction, so I was hoping you would add an ofmem_translate_inverse() or so, so that both could almost symmetrically use those functions, not just for ppc.
Possibly, although I took a glance at the hash table code and couldn't immediately get my head around how to come up with the reverse mapping. The good news is that these macros are designed for internal use only, so they only need to provide valid mappings for the ROM area which simplifies things a lot.
Ooops my bad. Does the attached patch look better?
Mostly, apart from the above issue. If you don't mind, I would apply this part myself tomorrow, moving your two functions down to avoid the static prototype and without my explanatory C++-style comment.
Okay - please do. You're probably the nearest person we have to a PPC maintainer at the moment so I'm happy to defer to you here.
ATB,
Mark.