On 13/04/2024 12:43, Mark Cave-Ayland wrote:
On 24/02/2024 18:25, Amadeusz Sławiński via OpenBIOS wrote:
Set of patches for few problems found when trying to build project. Also enable some additional checks and also fix issues found.
Amadeusz Sławiński (7): adb_kbd.c: Fix function key definitions Change malloc to take size_t as argument Label fallthroughs in switch()es Makefile.target: Enable few additional warnings Disable stack protector on all architectures bootstrap: Check result of fread Tell linker that stack is not executable
Makefile.target | 2 ++ arch/amd64/lib.c | 2 +- arch/ppc/build.xml | 8 ++++---- arch/ppc/ofmem.c | 2 +- arch/ppc/qemu/ofmem.c | 2 +- arch/sparc32/lib.c | 2 +- arch/sparc64/lib.c | 2 +- arch/x86/lib.c | 2 +- config/scripts/switch-arch | 14 +++++++------- drivers/adb_bus.c | 2 +- drivers/adb_kbd.c | 2 +- include/libc/stdlib.h | 2 +- kernel/bootstrap.c | 6 +++++- libc/vsprintf.c | 1 + 14 files changed, 28 insertions(+), 21 deletions(-)
Thanks for this series, and apologies it has taken me a while to look at it. In general this looks good and also coincides with some other build fixes I've been looking at with newer compilers reported by the Debian packagers.
We're nearly at the end of QEMU freeze so once that's over and I've validated these changes against my additional local build fixes, I'll apply these to git.
Pushed to master, thanks!
ATB,
Mark.