OpenBIOS September 2024

openbios@openbios.org

2 participants
5 discussions

[PATCH v3 0/3] esp: fixups to correctly terminate successful SCSI commands
by Mark Cave-Ayland 13 Sep '24

13 Sep '24

This series is an extension of the v2 patch with a couple of modifications to clear the FIFO at the start of the command, and to poll the ESP interrupt register to detect the end of the transfer. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> v3: - Clear FIFO before issuing ESP command - Poll ESP interrupt register to detect end of transfer v2: - Fix typo in commit message spotted by Zoltan Mark Cave-Ayland (3): esp: clear FIFO before issuing ESP command esp: use ESP rather than DMA interrupt to detect end of transfer esp: correctly terminate successful SCSI commands drivers/esp.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) -- 2.39.2

1 3

[PATCH v2] esp: correctly terminate successful SCSI commands
by Mark Cave-Ayland 11 Sep '24

11 Sep '24

An upcoming series for QEMU's ESP emulation will check that ESP commands are only issued according to their valid states as listed in the datasheet, and otherwise generate an illegal command interrupt. Currently if a SCSI command is expected to return no data or transfers data successfully, the ASC is not returned to its disconnected state. This means that any subsequent ESP initiator commands should be rejected until the SCSI bus transaction is terminated. Update the ESP driver so that if a SCSI command is successful then the ICCS and MSGACC commands are issued by the host to complete the SCSI transaction. This ensures that the ASC is returned to the disconnected state which allows the ESP to accept subsequent SCSI commands without generating an illegal command interrupt. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> --- drivers/esp.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) v2: - Fix typo in commit message spotted by Zoltan diff --git a/drivers/esp.c b/drivers/esp.c index 0880ab2..b1b10f4 100644 --- a/drivers/esp.c +++ b/drivers/esp.c @@ -113,7 +113,8 @@ do_command(esp_private_t *esp, sd_private_t *sd, int cmdlen, int replylen) return status; } if (replylen == 0) { - return 0; + /* No reply expected, ICCS and MSGACC to complete */ + goto done; } /* Target went to status phase instead of data phase? */ if ((status & ESP_STAT_PMASK) == ESP_STATP) { @@ -139,10 +140,18 @@ do_command(esp_private_t *esp, sd_private_t *sd, int cmdlen, int replylen) DPRINTF("do_command_reply: status 0x%x\n", status); - if ((status & ESP_STAT_TCNT) != ESP_STAT_TCNT) + if ((status & ESP_STAT_TCNT) != ESP_STAT_TCNT) { return status; - else - return 0; // OK + } + +done: + // ICCS and MSGACC sequence to complete + esp->ll->regs[ESP_CMD] = ESP_CMD_ICCSEQ; + (void)esp->ll->regs[ESP_FDATA]; // Ignore 1st byte for now + (void)esp->ll->regs[ESP_FDATA]; // Ignore 2nd byte for now + esp->ll->regs[ESP_CMD] = ESP_CMD_MOK; + + return 0; // OK } // offset is in sectors -- 2.39.2

1 1

[PATCH] esp: correctly terminate successful SCSI commands
by Mark Cave-Ayland 08 Sep '24

08 Sep '24

An upcoming series for QEMU's ESP emulation will check that ESP commands are only issued according to their valid states as listed in the datasheet, and otherwise generate an illegal command interrupt. Currently if a SCSI command is expected to return no data or transfers data successfully, the ASC is not returned to its disconnected state. This means that any subsequent ESP initiator commands should be rejected until the the SCSI bus transaction is terminated. Update the ESP driver so that if a SCSI command is successful then the ICCS and MSGACC commands are issued by the host to complete the SCSI transaction. This ensures that the ASC is returned to the disconnected state which allows the ESP to accept subsequent SCSI commands without generating an illegal command interrupt. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> --- drivers/esp.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/esp.c b/drivers/esp.c index 0880ab2..b1b10f4 100644 --- a/drivers/esp.c +++ b/drivers/esp.c @@ -113,7 +113,8 @@ do_command(esp_private_t *esp, sd_private_t *sd, int cmdlen, int replylen) return status; } if (replylen == 0) { - return 0; + /* No reply expected, ICCS and MSGACC to complete */ + goto done; } /* Target went to status phase instead of data phase? */ if ((status & ESP_STAT_PMASK) == ESP_STATP) { @@ -139,10 +140,18 @@ do_command(esp_private_t *esp, sd_private_t *sd, int cmdlen, int replylen) DPRINTF("do_command_reply: status 0x%x\n", status); - if ((status & ESP_STAT_TCNT) != ESP_STAT_TCNT) + if ((status & ESP_STAT_TCNT) != ESP_STAT_TCNT) { return status; - else - return 0; // OK + } + +done: + // ICCS and MSGACC sequence to complete + esp->ll->regs[ESP_CMD] = ESP_CMD_ICCSEQ; + (void)esp->ll->regs[ESP_FDATA]; // Ignore 1st byte for now + (void)esp->ll->regs[ESP_FDATA]; // Ignore 2nd byte for now + esp->ll->regs[ESP_CMD] = ESP_CMD_MOK; + + return 0; // OK } // offset is in sectors -- 2.39.2

2 3

[PATCH v2] README: change reference from LinuxBIOS to coreboot
by Mark Cave-Ayland 06 Sep '24

06 Sep '24

The linuxbios.org website does not exist anymore, so point the reader towards coreboot.org instead. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Resolves: https://github.com/openbios/openbios/issues/17 Reviewed-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> Tested-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v2: - Add R-B and T-B tags from Phil - Replace Coreboot with coreboot as indicated by Segher diff --git a/README b/README index 9f4b705..bf7684a 100644 --- a/README +++ b/README @@ -17,8 +17,8 @@ kernel and three interfaces for user interaction, device initialization and client (operating system) control. While far not all possible applications of OpenBIOS are implemented yet, -a lot of functionality is already there. OpenBIOS can be used to enhance -LinuxBIOS (http://www.linuxbios.org), or be booted from any multiboot +a lot of functionality is already there. OpenBIOS can be used as a payload +for coreboot (http://www.coreboot.org), or be booted from any multiboot capable bootloader to bring Open Firmware to your machine. OpenBIOS can also be used when an operating system is already running. It provides the needed OpenFirmware functionality to MOL (MacOnLinux) to boot MacOS -- 2.39.2

1 0

[PATCH] README: change reference from LinuxBIOS to Coreboot
by Mark Cave-Ayland 06 Sep '24

06 Sep '24

The linuxbios.org website does not exist anymore, so point the reader towards coreboot.org instead. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Resolves: https://github.com/openbios/openbios/issues/17 --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index 9f4b705..7e299b0 100644 --- a/README +++ b/README @@ -17,8 +17,8 @@ kernel and three interfaces for user interaction, device initialization and client (operating system) control. While far not all possible applications of OpenBIOS are implemented yet, -a lot of functionality is already there. OpenBIOS can be used to enhance -LinuxBIOS (http://www.linuxbios.org), or be booted from any multiboot +a lot of functionality is already there. OpenBIOS can be used as a payload +for Coreboot (http://www.coreboot.org), or be booted from any multiboot capable bootloader to bring Open Firmware to your machine. OpenBIOS can also be used when an operating system is already running. It provides the needed OpenFirmware functionality to MOL (MacOnLinux) to boot MacOS -- 2.39.2

3 3