June 2013 - OpenBIOS - mail.coreboot.org

[commit] r1138 - trunk/openbios-devel/forth/device
by repository service June 9, 2013

June 9, 2013

Author: mcayland Date: Sun Jun 9 14:24:52 2013 New Revision: 1138 URL: http://tracker.coreboot.org/trac/openbios/changeset/1138 Log: display.fs: Fix fb8-delete-lines within the inbuilt Forth terminal emulator. This enables us to provide a basic scrolling console terminal. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Modified: trunk/openbios-devel/forth/device/display.fs Modified: trunk/openbios-devel/forth/device/display.fs ============================================================================== --- trunk/openbios-devel/forth/device/display.fs Sun Jun 9 14:24:50 2013 (r1137) +++ trunk/openbios-devel/forth/device/display.fs Sun Jun 9 14:24:52 2013 (r1138) @@ -226,12 +226,12 @@ dup #columns = if drop 0 to column# line# 1+ - dup #lines = if - drop - \ FIXME move up screen (and keep position) - else - to #lines + dup #lines >= if + line# + 0 to line# + 1 delete-lines then + to line# else to column# then @@ -295,12 +295,12 @@ : fb8-delete-lines ( n -- ) \ numcopy = ( #lines - ( line# + n )) * char-height - #lines over #line + - char-height * + #lines over line# + - char-height * ( numcopy ) 0 ?do dup line# + char-height * i + line# char-height * i + - swap fb8-copy-line + fb8-copy-line loop #lines over - char-height *

1 0

[commit] r1137 - trunk/openbios-devel/forth/device
by repository service June 9, 2013

June 9, 2013

Author: mcayland Date: Sun Jun 9 14:24:50 2013 New Revision: 1137 URL: http://tracker.coreboot.org/trac/openbios/changeset/1137 Log: display.fs: Fix up default-font word. This enables us to execute "default-font set-font" as per the the IEEE1275 specification. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)ilande.co.uk> Modified: trunk/openbios-devel/forth/device/display.fs trunk/openbios-devel/forth/device/font.fs Modified: trunk/openbios-devel/forth/device/display.fs ============================================================================== --- trunk/openbios-devel/forth/device/display.fs Sat May 4 13:01:04 2013 (r1136) +++ trunk/openbios-devel/forth/device/display.fs Sun Jun 9 14:24:50 2013 (r1137) @@ -68,7 +68,7 @@ \ : default-font ( -- addr width height advance min-char #glyphs ) - \ (romfont-8x16) 8 10 10 0 100 + (romfont) (romfont-width) (romfont-height) (romfont-height) 0 100 ; : set-font ( addr width height advance min-char #glyphs -- ) Modified: trunk/openbios-devel/forth/device/font.fs ============================================================================== --- trunk/openbios-devel/forth/device/font.fs Sat May 4 13:01:04 2013 (r1136) +++ trunk/openbios-devel/forth/device/font.fs Sun Jun 9 14:24:50 2013 (r1137) @@ -9,5 +9,9 @@ \ the copyright and warranty status of this work. \ +0 value (romfont) +0 value (romfont-width) +0 value (romfont-height) + \ encode-file romfont.bin \ drop value (romfont-8x16)

1 0

Re: [OpenBIOS] [PATCHv2 00/20] Switch to standards-compliant Forth console from C console
by Mark Cave-Ayland June 2, 2013

June 2, 2013

On 01/06/13 17:21, Blue Swirl wrote: (lots cut) > Otherwise the patches look fine. Thanks for the review. I've fixed up the whitespace and linker issues, which leaves only the Debian 3.1r1 character issue (which is probably an unimplemented escape code). Are you happy for me to fix that up a bit later? At the moment I've got several in-progress patchsets related to the terminal/console of which this is the biggest, so it would help a lot to get it committed. ATB, Mark.

2 1